Fisheye on dgfirmware/firmware/App/Services/Reservoirs.h https://devapps.diality.us/changelog/~br%3Dmaster/dgfirmware/firmware/App/Services/Reservoirs.h Recent activity in "dgfirmware" under directory /firmware/App/Services/Reservoirs.h DG-DEN-14902-1: closed by Dara Navaei Fri, 15 Nov 2024 12:53:35 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei Closed DG-DEN-14902-1 ]]> DG-DEN-16587-2: closed by Dara Navaei Fri, 16 Feb 2024 10:59:25 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16587-2 https://devapps.diality.us/cru/DG-DEN-16587-2 Dara Navaei Closed DG-DEN-16587-2 ]]> DG-DEN-16587-2: reviewers finished Fri, 16 Feb 2024 10:59:15 -0800 https://devapps.diality.us/cru/DG-DEN-16587-2 https://devapps.diality.us/cru/DG-DEN-16587-2 Dara Navaei and Sean Nash finished reviewing DG-DEN-16587-2 DG-DEN-16587_Alarm 278 Rsvr Overfill Triggered During Treatment Reservoirs Filled TO 2000 ML P ]]> DG-DEN-16587-1: closed by Dara Navaei Fri, 16 Feb 2024 10:58:23 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16587-1 https://devapps.diality.us/cru/DG-DEN-16587-1 Dara Navaei Closed DG-DEN-16587-1 ]]> DG-DEN-16587-1: reviewers finished Fri, 16 Feb 2024 10:57:59 -0800 https://devapps.diality.us/cru/DG-DEN-16587-1 https://devapps.diality.us/cru/DG-DEN-16587-1 Dara Navaei finished reviewing DG-DEN-16587-1 DG-DEN-16587_Alarm 278 Rsvr Overfill Triggered During Treatment Reservoirs Filled TO 2000 ML ]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 15 Feb 2024 15:46:48 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=84989e158824d6cc8d8747ca80c6419315cc951c https://devapps.diality.us/changelog/dgfirmware?cs=84989e158824d6cc8d8747ca80c6419315cc951c Dara Navaei committed 84989e1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16674-td2-calibration-feature and 25 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-2, +2) | History | Source | Diff
]]> DG-DEN-16587-1: reviewers finished Thu, 15 Feb 2024 12:52:39 -0800 https://devapps.diality.us/cru/DG-DEN-16587-1 https://devapps.diality.us/cru/DG-DEN-16587-1 Sean Nash finished reviewing DG-DEN-16587-1 DG-DEN-16587_Alarm 278 Rsvr Overfill Triggered During Treatment Reservoirs Filled TO 2000 ML ]]> DG-DEN-16587-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 15 Feb 2024 12:52:35 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-1/#c19470 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19470 Sean Nash replied to Sean Nash in DG-DEN-16587-1

RESOLVED in CODE WALKTHROUGH.

]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function. Thu, 15 Feb 2024 12:16:52 -0800 Darren Cox <darren_m@cox.net> https://devapps.diality.us/changelog/dgfirmware?cs=3a007e014c41538a1256ce5f42093763db82e84d https://devapps.diality.us/changelog/dgfirmware?cs=3a007e014c41538a1256ce5f42093763db82e84d Darren Cox <darren_m@cox.net> committed 3a007e0 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16587-alarm-278-rsvr-overfill-triggered-during-treatment-reservoirs-filled-to-2000-ml and 26 more in dgfirmware DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

· /firmware/App/Modes/ModeGenIdle.c (-19, +31) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-0, +24) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-0, +1) | History | Source | Diff
]]> DG-DEN-16587-1: comment by Sean Nash "Question was in relation to DG gen idle sub-sta..." Thu, 15 Feb 2024 11:01:25 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-1/#c19469 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19469 Sean Nash replied to dcox  (deleted user) in DG-DEN-16587-1

Question was in relation to DG gen idle sub-state, not HD mode.

]]> DG-DEN-16587-1: comment by dcox "In pre-treat, there were transfers from one res..." Thu, 15 Feb 2024 09:51:41 -0800 dcox https://devapps.diality.us/cru/DG-DEN-16587-1/#c19468 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19468 dcox  (deleted user) replied to Sean Nash in DG-DEN-16587-1

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Treatment only.

]]> DG-DEN-16587-1: comment by Sean Nash "Why is this reservoir check only happening in t..." Thu, 15 Feb 2024 09:28:00 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-1/#c19467 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19467 Sean Nash commented on DG-DEN-16587-1

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen idle states).

]]> DG-DEN-16587-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH." Wed, 14 Feb 2024 14:37:32 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16587-1/#c19466 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19466 Vinayakam Mani replied to dcox  (deleted user) in DG-DEN-16587-1

RESOLVED IN CODE WALKTHROUGH.

]]> DG-DEN-16587-1: comment by dcox "Updated." Wed, 14 Feb 2024 14:15:11 -0800 dcox https://devapps.diality.us/cru/DG-DEN-16587-1/#c19465 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19465 dcox  (deleted user) replied to Vinayakam Mani in DG-DEN-16587-1

Updated.

]]> DG-DEN-16587-1: comment by Vinayakam Mani "DG idle reservoir out of range - rewording " DG..." Fri, 09 Feb 2024 09:40:55 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16587-1/#c19459 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19459 Vinayakam Mani commented on DG-DEN-16587-1

DG idle reservoir out of range - rewording " DG idle reservoir weight out of range" would be better?

]]> DG-DEN-16587-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 08 Feb 2024 13:48:18 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-2/#c19458 https://devapps.diality.us/cru/DG-DEN-16587-2/#c19458 Sean Nash replied to dcox  (deleted user) in DG-DEN-16587-2

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16587-2: comment by dcox "Updated." Thu, 08 Feb 2024 12:08:41 -0800 dcox https://devapps.diality.us/cru/DG-DEN-16587-2/#c19454 https://devapps.diality.us/cru/DG-DEN-16587-2/#c19454 dcox  (deleted user) replied to Sean Nash in DG-DEN-16587-2

Updated.

]]> DG-DEN-16587-1: comment by Dara Navaei "RESOLVED in CODE WLAKTHROUGH" Tue, 06 Feb 2024 12:36:37 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16587-1/#c19452 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19452 Dara Navaei replied to Dara Navaei in DG-DEN-16587-1

RESOLVED in CODE WLAKTHROUGH

]]> DG-DEN-16587-1: comment by Dara Navaei "This should be a fault alarm. Like the properti..." Thu, 01 Feb 2024 16:35:48 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16587-1/#c19370 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19370 Dara Navaei commented on DG-DEN-16587-1

This should be a fault alarm. Like the properties of alarm 189 (drain pump RPM out of range)

]]> DG-DEN-16587-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Tue, 06 Feb 2024 12:32:54 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16587-1/#c19451 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19451 Dara Navaei replied to Sean Nash in DG-DEN-16587-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-16587-2: comment by Sean Nash "Update properties and other alarm changes to ma..." Mon, 05 Feb 2024 13:42:24 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-2/#c19418 https://devapps.diality.us/cru/DG-DEN-16587-2/#c19418 Sean Nash commented on DG-DEN-16587-2

Update properties and other alarm changes to match -1 branch.

]]> DG-DEN-16587-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 05 Feb 2024 13:41:02 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-1/#c19417 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19417 Sean Nash replied to Sean Nash in DG-DEN-16587-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16587-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 05 Feb 2024 13:40:42 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-1/#c19416 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19416 Sean Nash replied to Sean Nash in DG-DEN-16587-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16587-1: comment by Sean Nash "Dara meant for you to add units to end of name ..." Mon, 05 Feb 2024 13:40:00 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-1/#c19415 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19415 Sean Nash replied to Dara Navaei in DG-DEN-16587-1

Dara meant for you to add units to end of name (i.e. MAX_IDLE_RSVR_WEIGHT_GAIN_ML).

]]> DG-DEN-16587-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 05 Feb 2024 13:39:12 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-1/#c19414 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19414 Sean Nash replied to Sean Nash in DG-DEN-16587-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16587-1: comment by Sean Nash "Use 2 U32 Data macro and log initial weight as ..." Fri, 02 Feb 2024 10:32:23 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-1/#c19394 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19394 Sean Nash commented on DG-DEN-16587-1

Use 2 U32 Data macro and log initial weight as well.

]]> DG-DEN-16587-1: comment by Sean Nash "inactive misspelled in comment." Fri, 02 Feb 2024 10:28:01 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-1/#c19393 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19393 Sean Nash commented on DG-DEN-16587-1

inactive misspelled in comment.

]]> DG-DEN-16587-1: comment by Sean Nash "This row needs to be updated." Fri, 02 Feb 2024 10:27:31 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16587-1/#c19392 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19392 Sean Nash commented on DG-DEN-16587-1

This row needs to be updated.

]]> DG-DEN-16587-1: comment by Dara Navaei "Please add the unit at the end of the #define" Thu, 01 Feb 2024 16:59:19 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16587-1/#c19371 https://devapps.diality.us/cru/DG-DEN-16587-1/#c19371 Dara Navaei commented on DG-DEN-16587-1

Please add the unit at the end of the #define

]]> DG-DEN-16587-2: started by Dara Navaei Wed, 31 Jan 2024 16:01:20 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16587-2 https://devapps.diality.us/cru/DG-DEN-16587-2 Dara Navaei started review DG-DEN-16587-2 ]]>