· /results/.gitignore

(-2, +2)

| History

| Source

| Diff

]]> Fri, 27 Oct 2023 09:33:26 -0700 Dara Navaei https://devapps.diality.us/cru/HD-UCOMMITS-28 https://devapps.diality.us/cru/HD-UCOMMITS-28 Dara Navaei Closed HD-UCOMMITS-28 ]]> Fri, 27 Oct 2023 09:33:09 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-28 https://devapps.diality.us/cru/HD-UCOMMITS-28 Sean Nash and Dara Navaei finished reviewing HD-UCOMMITS-28 HD Staging Unreviewed Commits ]]> Fri, 27 Oct 2023 09:21:49 -0700 Dara Navaei https://devapps.diality.us/cru/HD-UCOMMITS-28 https://devapps.diality.us/cru/HD-UCOMMITS-28 Dara Navaei started review HD-UCOMMITS-28 ]]> Fri, 27 Oct 2023 09:18:16 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=e254c20e850be27e0f21c33bed1a80c8f0e62dd5 https://devapps.diality.us/changelog/hdfirmware?cs=e254c20e850be27e0f21c33bed1a80c8f0e62dd5 Dara Navaei committed e254c20 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 104 more in hdfirmware Renamed some of the VectorCAST modules to be able to generate the html reports for them. Updated the .gitignore for the reuslts folder to ignore all the results folders

· /results/.gitignore	(-3, +4)	| History	| Source	| Diff
· /results/Build_Status_Report.csv	(-8, +0)	| History	| Source	| Diff

]]> Mon, 23 Oct 2023 15:18:20 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-116-1 https://devapps.diality.us/cru/HD-DENBUG-116-1 Dara Navaei Closed HD-DENBUG-116-1 ]]> Mon, 23 Oct 2023 13:08:23 -0700 https://devapps.diality.us/cru/HD-DENBUG-116-1 https://devapps.diality.us/cru/HD-DENBUG-116-1 jtaylor  (deleted user) , wbracken  (deleted user) and Sean Nash finished reviewing HD-DENBUG-116-1 HD-DENBUG-116_DG Allows Update OF Calibration Service System Records IN Other Modes Besides ]]> Mon, 23 Oct 2023 12:32:18 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=724c4c2a7dc9d1c101d9860bf869445980b4d1a2 https://devapps.diality.us/changelog/hdfirmware?cs=724c4c2a7dc9d1c101d9860bf869445980b4d1a2 Dara Navaei committed 724c4c2 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 105 more in hdfirmware DENBUG-116 updated the VectorCAST test cases

· /results/Build_Status_Report.csv

(-11, +3)

| History

| Source

| Diff

]]> Fri, 20 Oct 2023 11:20:12 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-116-1 https://devapps.diality.us/cru/HD-DENBUG-116-1 Dara Navaei started review HD-DENBUG-116-1 ]]> Fri, 20 Oct 2023 09:23:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 Dara Navaei Closed HD-DEN-16446-2 ]]> Fri, 20 Oct 2023 08:15:29 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 Sean Nash finished reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> Thu, 19 Oct 2023 16:37:30 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 wbracken  (deleted user) finished reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> Thu, 19 Oct 2023 16:36:33 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-16446-2/#c19222 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19222 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-16446-2

RESOLVED IN CODE WALKTHROUGH

The result will be an unsigned integer

RESOLVED in CODE WALKTHROUGH.

In the If conditions, we check "uFVolume > colUFVol" conditions, that makes uFRate always positive and hence the condition for minimum check is not required.

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

· /results/Build_Status_Report.csv

(-1, +13)

| History

| Source

| Diff

]]> Tue, 17 Oct 2023 15:00:28 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 jtaylor  (deleted user) resumed reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> Tue, 17 Oct 2023 14:59:23 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=c96f3fe49dd0a1ff8a53f55db572cf2dbdaee0d7 https://devapps.diality.us/changelog/hdfirmware?cs=c96f3fe49dd0a1ff8a53f55db572cf2dbdaee0d7 Dara Navaei committed c96f3fe on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 106 more in hdfirmware DEN-16446 updated the VectorCAST test cases

· /firmware/App/Controllers/Valves.c	(-1, +1)	| History	| Source	| Diff
· /results/Build_Status_Report.csv	(-218, +2)	| History	| Source	| Diff
· /results/VectorCAST.log	(-56892, +0)	| History	| Source	| Diff
· /results/cppcheck.log	(-177, +0)	| History	| Source	| Diff
· /results/cppcheckError.csv	(-95, +0)	| History	| Source	| Diff

]]> Mon, 16 Oct 2023 11:04:28 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16446-2/#c19033 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19033 Sean Nash commented on HD-DEN-16446-2

I think we need the minimum check too. uFRate can be negative if user sets volume to something lower than what has already been collected (negative volume) which would yield a negative rate which is < 0.0.