Fisheye on dgfirmware/firmware/App/Controllers/DrainPump.c

dgfirmware (release/p1b/master): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 07 Feb 2025 17:52:30 -0800

Dara Navaei committed da0deea on branch release/p1b/master in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

DG-DEN-14902-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:53:35 -0800

Dara Navaei Closed DG-DEN-14902-1

DG-DEN-16773-1: closed by Dara Navaei

Dara Navaei — Tue, 19 Mar 2024 18:20:47 -0700

Dara Navaei Closed DG-DEN-16773-1

DG-DEN-16773-1: reviewers finished

Tue, 19 Mar 2024 18:11:40 -0700

Sean Nash and Vinayakam Mani finished reviewing DG-DEN-16773-1

DG-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2

DG-DEN-16773-1: reviewers added to DG-DEN-16773_Add Chemical Disinfect Enable Institu...

Tue, 19 Mar 2024 17:26:41 -0700

Dara Navaei added pvedantam (deleted user) to DG-DEN-16773-1

DG-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 19 Mar 2024 16:15:20 -0700

Dara Navaei committed d820d5e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

DG-DEN-16773-1: started by Dara Navaei

Dara Navaei — Tue, 19 Mar 2024 16:11:07 -0700

Dara Navaei started review DG-DEN-16773-1

DG-DEN-16769-1: closed by Dara Navaei

Dara Navaei — Tue, 19 Mar 2024 15:55:23 -0700

Dara Navaei Closed DG-DEN-16769-1

DG-DEN-16769-1: reviewers finished

Mon, 18 Mar 2024 11:26:41 -0700

Sean Nash and Vinayakam Mani finished reviewing DG-DEN-16769-1

DG-DEN-16769_Alarm 280 DG Fault Drp Direction Fault

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16769 updated the VectorCAST test case for the drain pump

Dara Navaei — Mon, 18 Mar 2024 10:17:21 -0700

Dara Navaei committed 13e4021 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DEN-16769 updated the VectorCAST test case for the drain pump

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16769 changed the required minimum RPM for the drain pump direction check to 100 RPM

Dara Navaei — Mon, 18 Mar 2024 09:37:00 -0700

Dara Navaei committed 30f7327 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DEN-16769 changed the required minimum RPM for the drain pump direction check to 100 RPM

· /firmware/App/Controllers/DrainPump.c

(-1, +2)

| History

| Source

| Diff

DG-DEN-16769-1: reviewers added to DG-DEN-16769_Alarm 280 DG Fault Drp Direction Faul...

Mon, 18 Mar 2024 09:35:28 -0700

Dara Navaei added pvedantam (deleted user) to DG-DEN-16769-1

DG-DEN-16769_Alarm 280 DG Fault Drp Direction Fault

DG-DEN-16769-1: started by Dara Navaei

Dara Navaei — Mon, 18 Mar 2024 09:31:48 -0700

Dara Navaei started review DG-DEN-16769-1

DG-DEN-16682-3: closed by Dara Navaei

Dara Navaei — Mon, 11 Mar 2024 10:14:09 -0700

Dara Navaei Closed DG-DEN-16682-3

DG-DEN-16682-3: reviewers finished

Mon, 11 Mar 2024 10:13:39 -0700

Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16682-3

DG-DEN-16682_Use Cd2 Values For Acid Check

DG-DEN-16682-3: reviewers added to DG-DEN-16682_Use Cd2 Values For Acid Check

Mon, 11 Mar 2024 10:07:56 -0700

Dara Navaei added pvedantam (deleted user) to DG-DEN-16682-3

DG-DEN-16682_Use Cd2 Values For Acid Check

DG-DEN-16682-3: reviewers resumed

Fri, 08 Mar 2024 16:40:34 -0800

Michael Garthwaite resumed reviewing DG-DEN-16682-3

DG-DEN-16682_Use Cd2 Values For Acid Check

DG-DEN-16682-3: started by Dara Navaei

Dara Navaei — Thu, 07 Mar 2024 10:42:29 -0800

Dara Navaei started review DG-DEN-16682-3

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 07 Mar 2024 10:32:48 -0800

Dara Navaei committed ac029c3 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

DG-DEN-16682-2: closed by Dara Navaei

Dara Navaei — Thu, 07 Mar 2024 09:59:08 -0800

Dara Navaei Closed DG-DEN-16682-2

DG-DEN-16682-2: reviewers finished

Thu, 07 Mar 2024 09:55:51 -0800

Vinayakam Mani and Michael Garthwaite finished reviewing DG-DEN-16682-2

DG-DEN-16682_Use Cd2 Values For Acid Check

DG-DEN-16682-2: reviewers removed from DG-DEN-16682_Use Cd2 Values For Acid Check

Thu, 07 Mar 2024 09:48:35 -0800

Dara Navaei removed msuleiman (deleted user) from DG-DEN-16682-2

DG-DEN-16682_Use Cd2 Values For Acid Check

DG-DEN-16682-2: reviewers added to DG-DEN-16682_Use Cd2 Values For Acid Check

Thu, 07 Mar 2024 09:48:07 -0800

Dara Navaei added Behrouz NematiPour and msuleiman (deleted user) to DG-DEN-16682-2

DG-DEN-16682_Use Cd2 Values For Acid Check

DG-DEN-16682-2: reviewers resumed

Wed, 06 Mar 2024 14:48:51 -0800

Sean Nash resumed reviewing DG-DEN-16682-2

DG-DEN-16682_Use Cd2 Values For Acid Check

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-213 added a comment

Dara Navaei — Tue, 05 Mar 2024 08:55:09 -0800

Dara Navaei committed 00c11a5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

DENBUG-213 added a comment

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DEN-16682 upaded the drivers to get the calibration values once the signal is emitted. DENBUG-199 updated the drain pump...

Dara Navaei — Tue, 05 Mar 2024 08:14:46 -0800

Dara Navaei committed 7c5eba5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

DEN-16682 upaded the drivers to get the calibration values once the signal is emitted. DENBUG-199 updated the drain pump driver

· /firmware/App/Controllers/ConductivitySensors.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-0, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +3)	\| History	\| Source	\| Diff

DG-DEN-16682-2: reviewers added to DG-DEN-16682_Use Cd2 Values For Acid Check

Sat, 02 Mar 2024 18:38:39 -0800

Dara Navaei added pvedantam (deleted user) to DG-DEN-16682-2

DG-DEN-16682_Use Cd2 Values For Acid Check

DG-DEN-16674-2: closed by Dara Navaei

Dara Navaei — Fri, 01 Mar 2024 16:31:05 -0800

Dara Navaei Closed DG-DEN-16674-2

DG-DEN-16674-2: reviewers finished

Fri, 01 Mar 2024 16:21:45 -0800

Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16674-2

DG-DEN-16674_Td2 Calibration Feature

DG-DEN-16674-2: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH"

Vinayakam Mani — Fri, 01 Mar 2024 16:21:27 -0800

Vinayakam Mani replied to Dara Navaei in DG-DEN-16674-2

RESOLVED IN CODE WALKTHROUGH