Fisheye on dgfirmware/firmware/App/Controllers/UVReactors.c

DG-DEN-17047-1: closed by Dara Navaei

Dara Navaei — Sat, 08 Nov 2025 14:06:26 -0800

Dara Navaei Closed DG-DEN-17047-1

dgfirmware (release/p1b/master): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 07 Feb 2025 17:52:30 -0800

Dara Navaei committed da0deea on branch release/p1b/master in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

DG-DEN-14902-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:53:35 -0800

Dara Navaei Closed DG-DEN-14902-1

DG-DEN-17047-1: started by Dara Navaei

Dara Navaei — Tue, 10 Sep 2024 12:12:10 -0700

Dara Navaei started review DG-DEN-17047-1

DG-DENBUG-236-3: closed by Dara Navaei

Dara Navaei — Tue, 16 Apr 2024 10:19:51 -0700

Dara Navaei Closed DG-DENBUG-236-3

DG-DENBUG-236-3: reviewers finished

Tue, 16 Apr 2024 10:17:50 -0700

Sean Nash and Vinayakam Mani finished reviewing DG-DENBUG-236-3

DG-DENBUG-236_Alarm 97 When Running Treatmenet Vectorcast

DG-DENBUG-236-3: started by Dara Navaei

Dara Navaei — Tue, 16 Apr 2024 09:11:28 -0700

Dara Navaei started review DG-DENBUG-236-3

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 05 Apr 2024 16:58:31 -0700

Dara Navaei committed ae9755a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/UVReactors.c

(-1, +1)

| History

| Source

| Diff

DG-DENBUG-216-1: closed by Dara Navaei

Dara Navaei — Fri, 05 Apr 2024 16:47:58 -0700

Dara Navaei Closed DG-DENBUG-216-1

DG-DENBUG-216-1: reviewers finished

Fri, 05 Apr 2024 16:34:35 -0700

Vinayakam Mani and Sean Nash finished reviewing DG-DENBUG-216-1

DG-DENBUG-216_Alarm 89 Alarm ID DG Outlet UV Reactor ON With NO Flow Triggered During Chem Disinfect Flush

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): DENBUG-216 added code to clear the UV reactors with no flow and UV reactors health alarms when the UV reactor is off

Dara Navaei — Fri, 05 Apr 2024 15:24:06 -0700

Dara Navaei committed 158bf82 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 23 more in dgfirmware

DENBUG-216 added code to clear the UV reactors with no flow and UV reactors health alarms when the UV reactor is off

· /firmware/App/Controllers/UVReactors.c

(-1, +7)

| History

| Source

| Diff

DG-DENBUG-216-1: started by Dara Navaei

Dara Navaei — Fri, 05 Apr 2024 14:36:49 -0700

Dara Navaei started review DG-DENBUG-216-1

DG-DEN-16674-2: closed by Dara Navaei

Dara Navaei — Fri, 01 Mar 2024 16:31:05 -0800

Dara Navaei Closed DG-DEN-16674-2

DG-DEN-16674-2: reviewers finished

Fri, 01 Mar 2024 16:21:45 -0800

Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16674-2

DG-DEN-16674_Td2 Calibration Feature

DG-DEN-16674-2: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH"

Vinayakam Mani — Fri, 01 Mar 2024 16:21:27 -0800

Vinayakam Mani replied to Dara Navaei in DG-DEN-16674-2

RESOLVED IN CODE WALKTHROUGH

DG-DEN-16674-2: comment by Dara Navaei "Done"

Dara Navaei — Fri, 01 Mar 2024 15:50:52 -0800

Dara Navaei replied to Vinayakam Mani in DG-DEN-16674-2

Done

DG-DEN-16674-2: comment by Vinayakam Mani "Can we bring a parenthesis for better readabili..."

Vinayakam Mani — Fri, 01 Mar 2024 13:38:40 -0800

Vinayakam Mani commented on DG-DEN-16674-2

Can we bring a parenthesis for better readability?

DG-DEN-16674-2: reviewers added to DG-DEN-16674_Td2 Calibration Feature

Fri, 01 Mar 2024 10:54:45 -0800

Dara Navaei added Behrouz NematiPour to DG-DEN-16674-2

DG-DEN-16674_Td2 Calibration Feature

DG-DEN-16674-2: started by Dara Navaei

Dara Navaei — Fri, 01 Mar 2024 08:41:42 -0800

Dara Navaei started review DG-DEN-16674-2

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 29 Feb 2024 15:04:39 -0800

Dara Navaei committed e3839e1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 24 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

DG-DEN-16674-1: closed by Dara Navaei

Dara Navaei — Thu, 29 Feb 2024 14:45:27 -0800

Dara Navaei Closed DG-DEN-16674-1

DG-DEN-16674-1: reviewers finished

Thu, 29 Feb 2024 13:45:11 -0800

Sean Nash finished reviewing DG-DEN-16674-1

DG-DEN-16674_Td2 Calibration Feature

DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 29 Feb 2024 13:44:32 -0800

Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 29 Feb 2024 13:04:04 -0800

Dara Navaei replied to Sean Nash in DG-DEN-16674-1

Done

DG-DEN-16674-1: comment by Sean Nash "But this comment also asked that you remove the..."

Sean Nash — Thu, 29 Feb 2024 12:59:26 -0800

Sean Nash replied to Dara Navaei in DG-DEN-16674-1

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

DG-DEN-16674-1: comment by Dara Navaei "No I will check the Dialin check in the functio..."

Dara Navaei — Thu, 29 Feb 2024 12:51:48 -0800

Dara Navaei replied to Sean Nash in DG-DEN-16674-1

No I will check the Dialin check in the function like the rest of the commands from Dialin.

DG-DEN-16674-1: comment by Sean Nash "I don't see change. Did you push?"

Sean Nash — Thu, 29 Feb 2024 12:50:36 -0800

Sean Nash replied to Dara Navaei in DG-DEN-16674-1

I don't see change. Did you push?

DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 29 Feb 2024 12:50:11 -0800

Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 29 Feb 2024 12:49:56 -0800

Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 29 Feb 2024 12:49:34 -0800

Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.