application

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'master' into DEN-1396_LogHandler

    • -1
    • +1
    /sources/canbus/messageinterpreter.cpp
  1. … 22 more files in changeset.
http://dvm-linux02:8060/cru/UI-DEN-1396-1#c919

- Added classes details description.

- Added another define while I was adding description, I found out it's better to have another define so all the interface required would be as defines.

http://dvm-linux02:8060/cru/UI-DEN-1396-1#c855

- Added space and comment and also added a line to keep a backup copy of the denali bin which going to be overwritten.

Revision 56d00a8, line 98

- Added space between functions.

Updated the Copyright with the current year and replaced tabs with 4 spaces

    • -1
    • +1
    /sources/canbus/messageinterpreter.cpp
Merge branch 'DEN-1090_MessageHandler'

Merge branch 'master' into DEN-1090_MessageHandler

    • -1
    • +1
    /sources/gui/qml/components/ModalDialog.qml
    • -1
    • +1
    /sources/gui/qml/components/TouchRect.qml
    • -1
    • +1
    /sources/gui/qml/pages/SettingsHome.qml
  1. … 5 more files in changeset.
DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added a unit test project for miscellaneous test which is not covered on feature based unit tests.

- Added a simple unit test to test the coverage.

    • -0
    • +51
    /unittests/tst_utilities.cpp
    • -0
    • +50
    /unittests/tst_utilities.h
DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added unit tests for logging

- Added unit tests for Alarm message.

- Tested the logging and export with more than 150MB log and it took ~10 sec to copy so added some feature to disable USB/Export buttons during export.

- Instead of using QtCuncorrent which is asynchronous moved logger to a thread to take advantage of the Signal/Slot queue between threads to have events logged in order.

- Move USB/Export buttons on Treatment Screen.

- Moved export from file handler into Logger.

    • -2
    • +6
    /sources/gui/qml/components/ExportButton.qml
    • -0
    • +6
    /sources/gui/qml/components/USBButton.qml
    • -21
    • +0
    /sources/gui/qml/pages/TreatmentHome.qml
    • -0
    • +19
    /sources/gui/qml/pages/TreatmentStart.qml
  1. … 8 more files in changeset.
DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Ooooooopppps !

- Forgot a not in some classes.

DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added threading to other classes (Application / Gui controller, ...) and restructured the threading to meed the Qt limitation.

- Documented the code

- Ran cppCheck again

- Cleaned the includes and using namespace (They have left after so many changes and some were useless.)

- Added _init flag for init methods so not to be able to call them twice.

- Added another init method with the thread parameter to be able to pass the thread of the class and also be able to use the class without any thread for unit tests.

- Created a Threads namespace to gather all the threads in one place.

- Update the unit tests as well. [to make it work with the new structure/threading.]

    • -19
    • +0
    /sources/canbus/alarminterpreter.cpp
    • -29
    • +60
    /sources/canbus/caninterface.cpp
    • -21
    • +56
    /sources/canbus/frameinterface.cpp
    • -18
    • +17
    /sources/canbus/messagebuilder.h
    • -17
    • +56
    /sources/canbus/messagedispatcher.cpp
  1. … 21 more files in changeset.
DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added Threading for :

. Can Frame

. Can Message

. USB Watcher

- Changed the File Handler implementation

- Changed the Singleton from pointer to static reference

// TODO :

- We still need to work on threading on other classes

- We need to have a singleton parent class

- Some code has been added to debug can interface (We still have swap frames)

- Thread Objects need to be gathered all together in one place to be handled easily.

    • -17
    • +12
    /sources/applicationcontroller.cpp
    • -38
    • +84
    /sources/canbus/caninterface.cpp
    • -10
    • +38
    /sources/canbus/messagedispatcher.cpp
    • -0
    • +20
    /sources/canbus/messageglobals.cpp
  1. … 7 more files in changeset.
DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added Threading structure for USBWatcher and FileHandler

    • -51
    • +18
    /sources/storage/filehandler.cpp
DEN-1403 : Static Code Analysis

- cppCheck does not understand QML so even if a function is going to be used later in qml it still says not uded.

DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added a simple none secure Denali application update through USB drive

- Added check for the mount folders of the USB & SD-Card

DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Alarm Logging has been added

- Some other changes has been done to the code and messaging.

- Acknowledgment is not done [ Had an agreement with Sean for design but needs more time and we need to do it all together.]

    • -0
    • +95
    /sources/abstract/singleton.h
    • -0
    • +19
    /sources/canbus/alarminterpreter.cpp
    • -0
    • +41
    /sources/canbus/alarminterpreter.h
    • -116
    • +242
    /sources/canbus/messageinterpreter.cpp
    • -10
    • +30
    /sources/canbus/messageinterpreter.h
  1. … 22 more files in changeset.
Updated the Copyright with the current year and replaced tabs with 4 spaces

  1. … 38 more files in changeset.
Merge branch 'DEN-1090_MessageHandler' into DEN-1396_LogHandler

DEN-1090 : UI Message Handler / Error Handler

- Incomplete merge of the added feature for First parameter of the BloodFlow has to be unsigned int and changed to S32.

- Updated the unit tests.

    • -1
    • +11
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +8
    /sources/gui/qml/pages/TreatmentStart.qml
Merge branch 'DEN-1090_MessageHandler' into DEN-1396_LogHandler

- Added the changes to the BloodFlow first parameter form unsigned to signed to be updated.

    • -3
    • +3
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +2
    /sources/gui/qml/pages/TreatmentStart.qml
DEN-1090 : UI Message Handler / Error Handler

- First parameter of the BloodFlow has to be unsigned int and changed to S32.

    • -3
    • +7
    /sources/canbus/messageinterpreter.cpp
    • -7
    • +8
    /sources/gui/qml/pages/TreatmentStart.qml
DEN-1396 : UI Log Handler

MISC :

- Updated the Singleton defines to delete the instance.

- Added/moved the floatCompare in the types.cpp and created the file to do so.

LOGGING :

- Implemented logging

- Added LOG_EVENT / LOG_DATUM / LOG_ERROR in code instead of qDebug() as sample of the log event .

- Added export to USB feature.

- Added "Export Button"

    • -4
    • +15
    /sources/canbus/messageinterpreter.cpp
  1. … 11 more files in changeset.
DEN-1396 : UI Log Handler

- Added USB Drive Mount/Umount/Removed detection

- Added USB Drive mounting process error handling

- Added USB Button

- Made File Handler a singleton class which is connected to Main Timer to detect USB insertion and remove.

- Added series of connections in ApplicationController, Guicontroller, GuiView, FileHandler.

- Updated TouchRect to be able to notify user for reaction by fading in/out.

- Modified and added button colors for normal and selected.

- Added disabled functionality to the TouchRect

- Added USB button as a test into Home Screen.

    • -1
    • +1
    /sources/gui/qml/components/MainMenu.qml
    • -9
    • +53
    /sources/gui/qml/components/TouchRect.qml
    • -0
    • +51
    /sources/gui/qml/components/USBButton.qml
    • -15
    • +16
    /sources/gui/qml/globals/Colors.qml
    • -1
    • +1
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +2
    /sources/gui/qml/pages/TreatmentHome.qml
    • -32
    • +92
    /sources/storage/filehandler.cpp
DEN-1396 : UI Log Handler

- Added Detect/Mount USB drive (draft)

- It needs to be revised since it calls two part of the code that I don't know if it's reasonable.

DEN-1434 : UI In-Treatment Screen (Monitoring)

- Added "PWM Duty Cycle" parameter to BloodFlow Monitoring command

    • -2
    • +17
    /sources/canbus/messageinterpreter.cpp
    • -6
    • +15
    /sources/gui/qml/pages/TreatmentStart.qml
DEN-1090 : UI Message Handler / Error Handler

- Fixed a typo

DEN-1090 : UI Message Handler / Error Handler

- Fixed Comment Spacing [Code Review]

DEN-1090 : UI Message Handler / Error Handler

- Updated the constants by enums [Code Review]

    • -1
    • +1
    /sources/canbus/messageinterpreter.cpp
DEN-1090 : UI Message Handler / Error Handler

- Ran cppcheck and skiped unittests folder from cppcheck folders list.

Merge branch 'master' into DEN-1090_MessageHandler