hdfirmware / firmware / App / Controllers

AirPump.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 12 Jun 23
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 18 Oct 2023
8:49 pm

Dara Navaei

8:49 pm

Dara Navaei

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

8:48 pm

Dara Navaei

8:47 pm

Dara Navaei

HD-DEN-14344_SW S85 MG Air Pump
HD-DEN-14344_SW S85 MG Air Pump
Tuesday 03 Jan 2023
4:28 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./AirPump.h
  2. … 10 more files in changeset.
4:18 pm

wbracken  (deleted user) and Sean Nash

Thursday 29 Dec 2022
11:23 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:22 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:10 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

11:10 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

11:09 am

jtaylor  (deleted user)

9:47 am

Sean Nash

For a release build, looks like we would do nothing and get stuck in this state.

For a release build, looks like we would do nothing and get stuck in this state.

9:45 am

Sean Nash

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

Thursday 22 Dec 2022
1:35 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:33 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:29 pm

Michael Garthwaite

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

1:27 pm

Sean Nash

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

1:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:21 pm

Michael Garthwaite

DEN-14344: code review fixes.

Options
    • -0
    • +2
    ./AirPump.h
  2. … 2 more files in changeset.
1:19 pm

Michael Garthwaite

It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool

It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool

1:19 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:14 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.