Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control
HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Good point. Test will need to be longer than 50ms anyway - FPGA ramps the sound and there is a ~250ms time constant in the electronics. But I will want the sound to at least get started immediately.

Good point. Test will need to be longer than 50ms anyway - FPGA ramps the sound and there is a ~250ms time constant in the electronics. But I will want the sound to at least get started immediately.

Should we call setAlarmAudio here? This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

Should we call setAlarmAudio here?
This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This will be addressed in DEN-8103.

This will be addressed in DEN-8103.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Agreed. This is for me to add a check for this error. Will remove comment when I'm done.

Agreed. This is for me to add a check for this error. Will remove comment when I'm done.

Is this still an issue?

Is this still an issue?

Agreed. This is for me to add a check for this error. I'll remove comment when I'm done.

Agreed. This is for me to add a check for this error. I'll remove comment when I'm done.

Is this still an issue?

Is this still an issue?

Need to remove this comment.

Need to remove this comment.

Need to remove this comment.

Need to remove this comment.

Same as comment from DialinFlow.c

Same as comment from DialinFlow.c