dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 13 Sep 23
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 13 Sep 2023
9:52 am

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

On Dara's advice, ifdef'ed code for fill state treatment recovery

Options
    • -17
    • +12
    ./App/Modes/ModeFill.c
Tuesday 12 Sep 2023
10:55 am

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reset timers when doing a test recover state, or returning from a (reset) fault condition.

Options
    • -3
    • +5
    ./App/Modes/ModeFill.c
Friday 08 Sep 2023
5:23 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reintroduced reservoir data structure change.

Corrected the setModeFillStateTransition semantics.

Options
    • -2
    • +3
    ./App/Modes/ModeFill.c
    • -3
    • +0
    ./App/Services/Reservoirs.h
2:57 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Structure out of sync between HD/DG. Corrected.

Options
    • -0
    • +3
    ./App/Services/Reservoirs.h
1:27 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Corrected spacing in the file per CR comments

Options
    • -1
    • +3
    ./App/Modes/ModeFill.c
10:42 am

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Follow up for changes, simplifications suggested by Sean.

Options
    • -50
    • +24
    ./App/Modes/ModeFill.c
Thursday 07 Sep 2023
3:34 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Updated headers

Options
    • -1
    • +1
    ./App/Modes/ModeFill.c
3:27 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

fill time allowance for time spent in pause state

Cleared fill timer on transition to generate

Added removed unused (and uninitialized) variables from broadcast data structure.

Options
    • -2
    • +38
    ./App/Modes/ModeFill.c
    • -3
    • +0
    ./App/Services/Reservoirs.h
Friday 01 Sep 2023
4:38 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Initial changes for alarm 206 timer

Options
    • -21
    • +23
    ./App/Modes/ModeFill.c
    • -1
    • +1
    ./App/Services/Reservoirs.c
Thursday 31 Aug 2023
12:03 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
12:03 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Controllers/ConductivitySensors.c
    • -1
    • +1
    ./App/Controllers/Heaters.c
    • -2
    • +2
    ./App/Controllers/Pressures.c
    • -1
    • +1
    ./App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./App/Modes/ModeFault.c
    • -2
    • +2
    ./App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    ./App/Modes/ModeHeatDisinfect.h
9:14 am

Dara Navaei

DEN-16309 merged staging

Options
    • -6
    • +107
    ./App/Modes/ModeHeatDisinfect.c
    • -2
    • +6
    ./App/Modes/ModeHeatDisinfect.h
9:12 am

Dara Navaei

DEN-16309 addressed a code review comment

Options
    • -1
    • +1
    ./App/Modes/ModeChemicalDisinfect.c
Wednesday 30 Aug 2023
3:49 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
3:48 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Controllers/ConcentratePumps.c
    • -2
    • +2
    ./App/Controllers/ConcentratePumps.h
    • -2
    • +2
    ./App/Modes/ModeFill.c
    • -2
    • +2
    ./App/Services/SystemComm.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.h
3:25 pm

Vinayakam Mani

DEN-16093 changes merge in to staging

Options
    • -0
    • +4
    ./App/Services/SystemComm.c
    • -0
    • +21
    ./App/Services/SystemCommMessages.c
    • -0
    • +3
    ./App/Services/SystemCommMessages.h
2:48 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
2:48 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Modes/ModeHeatDisinfect.c
    • -2
    • +2
    ./App/Modes/ModeHeatDisinfect.h
    • -2
    • +2
    ./App/Services/SystemComm.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.c
    • -1
    • +1
    ./App/Services/SystemCommMessages.h
Tuesday 29 Aug 2023
4:56 pm

Dara Navaei

DEN-16323, DEN-16277 updated the chemical disinfect to get the level of the reservoir under disinfection more accurately

Options
    • -20
    • +59
    ./App/Modes/ModeChemicalDisinfect.c
12:38 pm

Dara Navaei

DEN-16309 updated the code. Changed the load cells' full level from 1900 to 1850 mL in heat disinfect to be consistent with the rest of the cleaning modes

Options
    • -0
    • +1
    ./App/Modes/ModeFault.c
    • -1
    • +1
    ./App/Modes/ModeHeatDisinfect.c
11:39 am

Michael Garthwaite

DIAL-281: Code review comments.

Options
    • -3
    • +3
    ./App/Modes/ModeHeatDisinfect.c
9:34 am

Michael Garthwaite

DIAL-278: implementation of heat disinfection state timer overrides.

Options
    • -4
    • +105
    ./App/Modes/ModeHeatDisinfect.c
    • -0
    • +4
    ./App/Modes/ModeHeatDisinfect.h
    • -0
    • +8
    ./App/Services/SystemComm.c
    • -0
    • +64
    ./App/Services/SystemCommMessages.c
    • -1
    • +7
    ./App/Services/SystemCommMessages.h
Monday 28 Aug 2023
3:28 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
9:36 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
9:36 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./App/Modes/OperationModes.c
8:43 am

Dara Navaei

DEN-16309 added a new heat disinfect state

Options
    • -7
    • +11
    ./App/Controllers/Heaters.c
    • -10
    • +62
    ./App/Modes/ModeHeatDisinfect.c
    • -0
    • +1
    ./App/Modes/ModeHeatDisinfect.h
Sunday 27 Aug 2023
3:51 pm

Dara Navaei

DEN-16309 removed the clearance period some of the persistence alarms

Options
    • -2
    • +2
    ./App/Controllers/ConductivitySensors.c
    • -3
    • +3
    ./App/Controllers/Heaters.c
    • -4
    • +4
    ./App/Controllers/Pressures.c
Friday 25 Aug 2023
2:50 pm

Vinayakam Mani

DEN-16093 fixed code review comments

Options
    • -2
    • +5
    ./App/Modes/ModeFill.c
1:21 pm

Vinayakam Mani

DEN-16093-Increased conductivity percentage check and time out values

Options
    • -3
    • +3
    ./App/Modes/ModeFill.c
1:06 pm

Vinayakam Mani

take latest changes from staging

Options
    • -5
    • +13
    ./App/Modes/ModeFill.c
    • -4
    • +58
    ./App/Services/SystemComm.c
    • -5
    • +69
    ./App/Services/SystemCommMessages.c
    • -1
    • +7
    ./App/Services/SystemCommMessages.h