hdfirmware / firmware / source

adc.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 12 Sep 23
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Oct 2023
9:33 am

Dara Navaei

9:33 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

9:31 am

Dara Navaei

9:31 am

Dara Navaei

HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control
HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control
8:40 am

Dara Navaei

8:40 am

Dara Navaei

8:40 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

8:39 am

Dara Navaei

HD-DEN-3115_HD Blood Flow 3 of 3
HD-DEN-3115_HD Blood Flow 3 of 3
Thursday 10 Jun 2021
3:22 pm

Sean Nash

3:04 pm

qnguyen  (deleted user) , Dara Navaei and pmontazemi  (deleted user)

Monday 07 Jun 2021
10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:27 am

Sean Nash

Good point. Test will need to be longer than 50ms anyway - FPGA ramps the sound and there is a ~250ms time constant in the electronics. But I will want the sound to at least get started immediately.

Good point. Test will need to be longer than 50ms anyway - FPGA ramps the sound and there is a ~250ms time constant in the electronics. But I will want the sound to at least get started immediately.

Friday 04 Jun 2021
10:31 am

qnguyen  (deleted user)

Should we call setAlarmAudio here? This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

Should we call setAlarmAudio here?
This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

Friday 28 May 2021
10:34 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 27 May 2021
10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 18 May 2021
10:42 am

qnguyen  (deleted user)

This will be addressed in DEN-8103.

This will be addressed in DEN-8103.

10:40 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 11 May 2021
2:54 pm

Sean Nash

Agreed. This is for me to add a check for this error. Will remove comment when I'm done.

Agreed. This is for me to add a check for this error. Will remove comment when I'm done.

2:54 pm

Sean Nash

Is this still an issue?

Is this still an issue?

2:53 pm

Sean Nash

Agreed. This is for me to add a check for this error. I'll remove comment when I'm done.

Agreed. This is for me to add a check for this error. I'll remove comment when I'm done.

2:53 pm

Sean Nash

Is this still an issue?

Is this still an issue?

Friday 07 May 2021
12:07 am

qnguyen  (deleted user)

Need to remove this comment.

Need to remove this comment.

12:07 am

qnguyen  (deleted user)

Need to remove this comment.

Need to remove this comment.

12:06 am

qnguyen  (deleted user)

Same as comment from DialinFlow.c

Same as comment from DialinFlow.c

12:06 am

qnguyen  (deleted user)

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again. Suggest creating a ...

We can't have 3 calls to isPersistentAlarmTriggered() on same alarm. If the first call starts the timer and the second or third call is good, it will reset the timer to 0 again.
Suggest creating a BOOL variable to have all three conditions or with each other and call isPersistentAlarmTriggered() only once.

Thursday 06 May 2021
10:27 am

Sean Nash

initBloodPrime() is called every time we transition to blood prime sub-mode.

initBloodPrime() is called every time we transition to blood prime sub-mode.

Wednesday 05 May 2021
7:57 pm

qnguyen  (deleted user)

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?