Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
UI-DEN-2087-1 : Code Review Comments

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 2 more files in changeset.
DEN-2236_UI100%CoverageoftheApplicationSoftware

level 1

Coverage : 99.594% (1473/1479)

Manual : 15.416% (228/1479)

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 37 more files in changeset.
DEN-2236_UI100%CoverageoftheApplicationSoftware

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 1 more file in changeset.
DEN-2236_UI100%CoverageoftheApplicationSoftware

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 2 more files in changeset.
DEN-2236_UI100%CoverageoftheApplicationSoftware

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 9 more files in changeset.
DEN-2236_UI100%CoverageoftheApplicationSoftware

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 13 more files in changeset.
DEN-2236_UI100%CoverageoftheApplicationSoftware

- Fixed the dev build version for every build

- Fixed alarm status notification

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 3 more files in changeset.
DEN-2236_UI100%CoverageoftheApplicationSoftware

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-2236_UI100%CoverageoftheApplicationSoftware

- Fixed the Alarm on NotificationBar

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 1 more file in changeset.
DEN-2236_UI100%CoverageoftheApplicationSoftware

- tst_utilities and tst_logging are now 100% covered.

- Changed the TouchRect parent from Item to Rectangle to be identified by Squish Qt as an object on its parent.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 7 more files in changeset.
DEN-2087 : UI Blood/Dialysate Flow Rate Adjustment

- Fixed the Blood/Dialysate Adjustment bug on Adjustment dialog

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 9 more files in changeset.
DEN-2087 : UI Blood/Dialysate Flow Rate Adjustment

- Changed the FLOWS section of the Treatment screen to show the Blood/Dialysate set flow rate points.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-2087 : UI Blood/Dialysate Flow Rate Adjustment

- Added Message handling for Treatment Ranges since the Blood/Dialysate requires that message to be handled and acked by UI Application.

- VTreatmentRanges and MTreatmentRanges added

- Fixed the message 23 for Treatment Adjustment Request which used U32 not F32.

- Prepared some screen to be able to adjust ranges.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +7
    ./qml/pages/treatment/TreatmentStack.qml
    • -4
    • +15
    ./qml/pages/treatment/TreatmentStart.qml
  1. … 14 more files in changeset.
DEN-2087 : UI Blood/Dialysate Flow Rate Adjustment

- Added first implementation of the NotificationBar.

- Added Blood/Dialysate Adjustment Request Denali Message

- Removed Alerts from settings home since it has been added in NotificationBar.

- VTreatmentAdjustmentsResponse view class

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +68
    ./qml/components/NotificationBar.qml
  1. … 13 more files in changeset.
DEN-2087 : UI Blood/Dialysate Flow Rate Adjustment

- Added Denali Message 23 : Blood/dialysate rate Change

23, 0x100, 9, Req, Y, UI, HD, Blood/dialysate rate Change, (U32) Blood rate, (U32) Dialysate rate

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +1
    ./qml/pages/treatment/TreatmentStack.qml
  1. … 7 more files in changeset.
DEN-2087 : UI Blood/Dialysate Flow Rate Adjustment

- Modified mL => mL/min for Blood/Dialysate Flow Unit

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 2 more files in changeset.
DEN-2087 : UI Blood/Dialysate Flow Rate Adjustment

- Code Optimization

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 1 more file in changeset.
DEN-2087 : UI Blood/Dialysate Flow Rate Adjustment

- As an example of adding a view in the Application, Pressure/Occlusion data has been added.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 4 more files in changeset.
DEN-2087 : UI Blood/Dialysate Flow Rate Adjustment

- Some Code Clean up

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 12 more files in changeset.
DEN-2087 : UI Blood/Dialysate Flow Rate Adjustment

- An Example of adding a model into the Application (Adding a Denali Message (Model)).

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 7 more files in changeset.
DEN-2087_BloodDialysateFlowAdjustment

- Added TreatmentAdjustmentBase as the base screen for all the Treatment Adjustment screens.

- Removing unnecessary imports

- Added TickMarks component for Slider (ranges).

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +63
    ./qml/components/TickMarks.qml
  1. … 27 more files in changeset.
DEN-2087_BloodDialysateFlowAdjustment

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -0
    • +46
    ./qml/components/CloseButton.qml
    • -0
    • +38
    ./qml/components/ConfirmButton.qml
    • -0
    • +74
    ./qml/components/ModelessDialog.qml.WIP
    • -23
    • +19
    ./qml/components/ProgressBar.qml
    • -0
    • +48
    ./qml/components/ProgressBarEx.qml
    • -0
    • +114
    ./qml/components/Slider.qml
  1. … 12 more files in changeset.
Code Review Comments

- Dara also mentioned I need to have copyright at the beginning of the scripts.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 12 more files in changeset.
DEN-2088 : Implementation

- Redesigned the model.cpp/h file

- Made View registration in one place and easier.

- Added views definition in main.qml (not all of them belong here and should be revised when debug screen (SettingHome) removed.)

- Added PowerOff Model

- Added PowerOff View

- Modified MessageInterpreter to apply the new PowerOff MV

- Added TreatmentFlows Model

- Added TreatmentOutletFlow Model

- Added TreatmentTime Model

- Improved TreatmentTime View

- Improved Types

- Added AlarmStatus Model

- Improved AlarmStatus View to be modified easier

- Improved TreatmentUltrafiltration View

- Added vview.h to be able to maintain view classes easier.

- Separated BloodFlow and DialysateFlow

- Updated Debug Screen (SettingHome) with the new views of the BloodFlow and DialysateFlow Views

- Updated TreatmentFlows section with the new views of the BloodFlow and DialysateFlow

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -42
    • +0
    ./view/vtreatmentultrafiltration.cpp
  1. … 32 more files in changeset.
DEN-2088 Implementation

- Added OutletFlow

- Added TreatmentTime

- Added AlarmStatus

- Made adding model view simpler

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -15
    • +0
    ./qml/pages/treatment/TreatmentStart.qml
    • -0
    • +49
    ./view/valarmstatus.cpp
    • -0
    • +57
    ./view/valarmstatus.h
    • -0
    • +38
    ./view/vtreatmenttime.cpp
    • -0
    • +48
    ./view/vtreatmenttime.h
  1. … 16 more files in changeset.
DEN-2088 : Implementation (3 of 4)

- Bloodflow , DialysateFlow models implemented and proper changes has been made

- Alerts, Dialysate out needs to be modified

- Pressure / Occlusion Data needs to be implemented.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -6
    • +0
    ./qml/pages/treatment/TreatmentStart.qml
    • -0
    • +56
    ./view/vtreatmentflows.cpp
    • -0
    • +59
    ./view/vtreatmentflows.h
  1. … 10 more files in changeset.
DEN-2091 : CAN / Denali Communication Protocol [Modify Design]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 15 more files in changeset.
DEN-UI-1971 : Peman's comments

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 1 more file in changeset.
DEN-1974 : Unit Testing / DEN-1975 : Integration Testing

- Modified application to be more testable for unit/integration tests.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-1973 : Implementation

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 2 more files in changeset.