dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 03 Aug 20
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 03 Aug 2020
3:48 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4184: Added ADC reading equal fullscale unit test

Options
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
9:19 am

Quang Nguyen <qnguyen@diality.com>

Updated message id for drain pump set rpm override

Options
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
8:50 am

Quang Nguyen <qnguyen@diality.com>

DEN-4184: Added back doxygen comments

Options
    • -14
    • +14
    /firmware/App/Controllers/Pressures.c
Friday 31 Jul 2020
3:09 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Updated unit tests for temperature sensors

Options
    • -2
    • +2
    /results/Build_Status_Report.csv
    • -443
    • +622
    /results/VectorCAST.log
    • -45
    • +50
    /results/cppcheck.log
    • -37
    • +46
    /results/cppcheckError.csv
1:32 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Fixed alignment and function header description

Options
    • -16
    • +15
    /firmware/App/Controllers/TemperatureSensors.c
10:53 am

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Added persistence for FPGA error and time sense for persistence count

Options
    • -38
    • +49
    /firmware/App/Controllers/TemperatureSensors.c
10:01 am

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Fixed alignment per code reviews

Options
    • -9
    • +8
    /firmware/App/Controllers/Heaters.c
    • -12
    • +12
    /firmware/App/Controllers/TemperatureSensors.c
Thursday 30 Jul 2020
4:06 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Fixed comments

Options
    • -3
    • +3
    /firmware/App/Controllers/TemperatureSensors.c
3:30 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Added consistency in temperature sensor index param

Options
    • -11
    • +11
    /firmware/App/Controllers/TemperatureSensors.c
    • -3
    • +3
    /firmware/App/Controllers/TemperatureSensors.h
2:57 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Corrected styling and comments

Options
    • -25
    • +38
    /firmware/App/Controllers/TemperatureSensors.c
1:27 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Fixed unit tests and update self test check

Options
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
12:24 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4184: Added alarms when inlet water pressure low

Options
    • -46
    • +65
    /firmware/App/Controllers/Pressures.c
    • -2
    • +1
    /firmware/App/Controllers/Pressures.h
    • -3
    • +4
    /firmware/App/Modes/ModeDrain.c
    • -3
    • +5
    /firmware/App/Modes/ModeFill.c
    • -3
    • +6
    /firmware/App/Modes/ModeRecirculate.c
Wednesday 29 Jul 2020
4:21 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Separate high and low temperature alarms

Options
    • -10
    • +22
    /firmware/App/Controllers/TemperatureSensors.c
2:12 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Added doxygen comment and rename variable

Options
    • -32
    • +33
    /firmware/App/Controllers/TemperatureSensors.c
12:20 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Refacor POST tests

Options
    • -6
    • +18
    /firmware/App/Controllers/TemperatureSensors.c
11:56 am

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Rename temperature sensors enumeration

Options
    • -2
    • +2
    /firmware/App/Controllers/ConductivitySensors.c
    • -12
    • +12
    /firmware/App/Controllers/Heaters.c
    • -55
    • +55
    /firmware/App/Controllers/TemperatureSensors.c
    • -13
    • +13
    /firmware/App/Controllers/TemperatureSensors.h
9:53 am

Quang Nguyen <qnguyen@diality.com>

DEN 4184: Added self test for pressure sensors

Options
    • -25
    • +72
    /firmware/App/Controllers/Pressures.c
    • -1
    • +1
    /firmware/App/Controllers/Pressures.h
    • -0
    • +6
    /firmware/App/Modes/ModeInitPOST.c
Monday 27 Jul 2020
2:11 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Check inlet water temperature in Fill, Drain, and Re-circulate modes

Options
    • -28
    • +49
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +1
    /firmware/App/Controllers/TemperatureSensors.h
    • -0
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -0
    • +2
    /firmware/App/Modes/ModeFill.c
    • -0
    • +2
    /firmware/App/Modes/ModeRecirculate.c
Friday 24 Jul 2020
5:29 pm

Quang Nguyen <qnguyen@diality.com>

DEN-4169: Restructure temperature sensor module

Options
    • -185
    • +140
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +8
    /firmware/App/Controllers/TemperatureSensors.h
2:02 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/DGCommon.h
2:02 pm

Dara Navaei

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.h
    • -2
    • +2
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Controllers/Heaters.c
    • -2
    • +2
    /firmware/App/Controllers/LoadCell.c
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -2
    • +2
    /firmware/App/Controllers/Valves.c
    • -2
    • +2
    /firmware/App/Drivers/InternalADC.c
    • -2
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -2
    • +2
    /firmware/App/Modes/ModeFill.c
    • -2
    • +2
    /firmware/App/Modes/ModeRecirculate.c
    • -2
    • +2
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +2
    /firmware/App/Modes/OperationModes.c
  16. … 12 more files in changeset.
1:55 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-3922-dg-inlet-water-quality' into master

Options
1:35 pm

Quang Nguyen <qnguyen@diality.com>

Added software fault id to support utility change

Options
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
Thursday 23 Jul 2020
9:32 am

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Added missing break in switch case

Options
    • -0
    • +1
    /firmware/App/Services/SystemComm.c
Wednesday 22 Jul 2020
5:28 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Added doxygen comments

Options
    • -5
    • +5
    /firmware/App/Services/MsgQueues.c
    • -2
    • +1
    /firmware/App/Services/PIControllers.c
2:49 pm

Quang Nguyen <qnguyen@diality.com>

Clean up all import errors in vector cast

Options
    • -2
    • +1
    /results/Build_Status_Report.csv
    • -821
    • +606
    /results/VectorCAST.log
2:23 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Addressed code reviews

Options
    • -1
    • +1
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +0
    /firmware/App/Controllers/DrainPump.c
    • -3
    • +0
    /firmware/App/Services/AlarmMgmt.c
    • -3
    • +0
    /firmware/App/Services/MsgQueues.c
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -238
    • +238
    /results/VectorCAST.log
    • -0
    • +1
    /results/cppcheck.log
Tuesday 21 Jul 2020
8:56 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Addressed code reviews and removed VC previous import errors

Options
    • -12
    • +18
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +0
    /firmware/App/Controllers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Controllers/DrainPump.c
    • -3
    • +3
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/LoadCell.c
    • -2
    • +2
    /firmware/App/Controllers/Pressures.c
    • -2
    • +2
    /firmware/App/Controllers/ROPump.c
    • -2
    • +2
    /firmware/App/Controllers/TemperatureSensors.c
    • -3
    • +3
    /firmware/App/Controllers/Valves.c
    • -2
    • +2
    /firmware/App/Drivers/InternalADC.c
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
  16. … 13 more files in changeset.
11:59 am

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Addressed code reviews and removed VC previous import errors

Options
    • -25
    • +32
    /firmware/App/Controllers/ConductivitySensors.c
    • -2
    • +2
    /firmware/App/Controllers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -3
    • +1
    /firmware/App/Modes/ModeFill.c
    • -3
    • +3
    /firmware/App/Modes/ModeRecirculate.c
    • -1
    • +1
    /results/Build_Status_Report.csv
    • -968
    • +377
    /results/VectorCAST.log
    • -1
    • +1
    /results/cppcheckError.csv
Monday 20 Jul 2020
1:59 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3922 Fixed doxygen errors and corrected spelling errors

Options
    • -6
    • +8
    /firmware/App/Controllers/ConductivitySensors.c
    • -5
    • +7
    /firmware/App/Controllers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Modes/ModeDrain.c
    • -1
    • +1
    /firmware/App/Modes/ModeFill.c
    • -1
    • +1
    /firmware/App/Modes/ModeRecirculate.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +1
    /results/Build_Status_Report.csv
    • -347
    • +592
    /results/VectorCAST.log