DG-DEN-4169-1 DG-DEN-4169_DG Inlet Water Temperature - Closed

closed on 03 Aug 20

Author

Moderator

Reviewers

DG-DEN-4169_DG Inlet Water Temperature

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 9

common 0
- File AlarmDefs.h 0 Remove
dgfirmware 0
- Folder firmware/App 0
  - Folder Controllers 0
    - File ConductivitySensors.c 0 Remove
    - File Heaters.c 3 Remove
    - File TemperatureSensors.c 39 Remove
    - File TemperatureSensors.h 0 Remove
  - Folder Modes 0
    - File ModeDrain.c 0 Remove
    - File ModeFill.c 0 Remove
    - File ModeRecirculate.c 0 Remove
fwcommon 0
- File Utilities.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
qnguyen (deleted user)	Author & Moderator	1h 14m	15	Done
Sean Nash	Reviewer - Complete	1h 2m	11	RESOLVED in CODE WALKTHROUGH.
Dara Navaei	Reviewer - Complete	33m	5	RESOLVED in CODE WALKTRHOUGH
pmontazemi (deleted user)	Reviewer - Complete	25m	11	RESOLVED in CODE WALKTHROUGH.
Total		3h 16m	42

Linked issues
- DEN-4169

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Repository common (common) is not running.

Repository dgfirmware (dgfirmware) is not running.

Repository dgfirmware (dgfirmware) is not running.

Repository dgfirmware (dgfirmware) is not running.

Repository dgfirmware (dgfirmware) is not running.

Repository dgfirmware (dgfirmware) is not running.

Repository dgfirmware (dgfirmware) is not running.

Repository dgfirmware (dgfirmware) is not running.

Click to load diff

Atlassian Fisheye analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-08-21 14:37 -0700

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

Full notation guide

Log time