Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-4308 addressed code review comments

  1. … 16 more files in changeset.
DEN-4211: Added 2 sec delay before power off. Added HD valves support to EMC build.

  1. … 6 more files in changeset.
Added dialin messages for dialysate inlet pump. Fixes to watchdog expired fault. Updates to existing UT.

  1. … 10 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Spaces between 0s.

Spaces between 0s.

Fixed white space between brackets throughout. Added some debug code to help troubleshoot comm issue. Updated power off messaging. +review HD-DEN-759-1

  1. … 153 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

In group setting, decision was made to use the () rules applied to [].

In group setting, decision was made to use the () rules applied to [].

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

What is the rule for arguments between [ ] ? Does it need spacing like ( ) ?

What is the rule for arguments between [ ] ? Does it need spacing like ( ) ?

Done.

Done.

Agreed.

Agreed.

Fixed.

Fixed.

Sorry - must have changed a different line of code. Now done.

Sorry - must have changed a different line of code. Now done.

Spaces between arithmetic sign and arguments, also did you want to add spaces between (v, l, and u)? If so, we need to do it everywhere in this code and everywhere else.

Spaces between arithmetic sign and arguments, also did you want to add spaces between (v, l, and u)? If so, we need to do it everywhere in this code and everywhere else.

I thought we agreed to have spaced between arguments and parentheses?

I thought we agreed to have spaced between arguments and parentheses?

I thought we agreed to have spaced between arguments and parentheses?

I thought we agreed to have spaced between arguments and parentheses?

I thought we agreed to have spaced between arguments and parentheses?

I thought we agreed to have spaced between arguments and parentheses?

Addressed code review feedback. Fixed an intermittent CAN bug. Updated UT for Buttons, CPLD, and Interrupts modules. +review HD-DEN-759-1

  1. … 16 more files in changeset.
Done.

Done.