Activity hdfirmware/firmware/App/Modes/ModeTreatment.c

Bad practice to have two calls to same function here. Possible that 2nd call will return different result. Should call function once to assign value to a local var prior to if statement and then re...

Bad practice to have two calls to same function here. Possible that 2nd call will return different result.
Should call function once to assign value to a local var prior to if statement and then reference the local var in the if statement.

12:26 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

10:54 am

Dara Navaei

More
Re: HD-DENBUG-298-1
replied to Sean Nash

Yes. I think we should have these events to information.

10:40 am

Dara Navaei

More
a99ba4c
changed 1 file
DEN-17271-saline-bolus-doxygen-update, DEN-17273-release_21_cpp_check_fix_staging and 7 more HD-DENBUG-298-1

DENBUG-298 updated the VectorCAST test cases

- -1
- +2
./ModeTreatment.c
- History
- Source
- Diff
./ModeTreatment.c

9:00 am

Sean Nash

More
Re: HD-DENBUG-298-1
commented on review

Are these permanent?

5:30 pm

Dara Navaei

More
66c0967
changed 1 file
DEN-17271-saline-bolus-doxygen-update, DEN-17273-release_21_cpp_check_fix_staging and 7 more HD-DENBUG-298-1

DENBUG-320 cleaned up the code

- -11
- +8
./ModeTreatment.c
- History
- Source
- Diff
./ModeTreatment.c

3:21 pm

Dara Navaei

More
22fef1f
changed 5 files
DEN-17271-saline-bolus-doxygen-update, DEN-17273-release_21_cpp_check_fix_staging and 7 more HD-DENBUG-298-1

DENBUG-302 updated the confirmation function to receive the 4 payloads to be sent up

- -1
- +2
./ModeTreatment.c
- History
- Source
- Diff
./ModeTreatment.c
… 4 more files in changeset.

4:57 pm

Dara Navaei

More
ab30d3e
changed 1 file
DEN-17271-saline-bolus-doxygen-update, DEN-17273-release_21_cpp_check_fix_staging and 7 more HD-DENBUG-298-1

DENBUG-302 added a timeout to the UF rate confirmation screen

- -2
- +20
./ModeTreatment.c
- History
- Source
- Diff
./ModeTreatment.c

8:34 am

Sean Nash

More
Re: HD-DENBUG-298-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

9:05 am

Sean Nash

More
Re: HD-DENBUG-298-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

4:45 pm

Dara Navaei

More
4b277cb
changed 1 file
DEN-17271-saline-bolus-doxygen-update, DEN-17273-release_21_cpp_check_fix_staging and 7 more HD-DENBUG-298-1

DENBUG-302 changed the UF rate that is reported to UI in mL/min

- -1
- +1
./ModeTreatment.c
- History
- Source
- Diff
./ModeTreatment.c

1:17 pm

Sean Nash

More
Re: HD-DENBUG-298-1
commented on review

Add comment explaining what we're doing here.

1:17 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

1:15 pm

Dara Navaei

More
Re: HD-DENBUG-298-1
replied to Sean Nash

Moved it to OperationModes

1:14 pm

Dara Navaei

More
3eb378d
changed 4 files
DEN-17271-saline-bolus-doxygen-update, DEN-17273-release_21_cpp_check_fix_staging and 7 more HD-DENBUG-298-1

DENBUG-302 updated the code to check for the UF rate confirmation in operation mode. DEN-17237 changed the code to re-trigger the placeholder cleaning mode alarms if they got cleared

- -22
- +29
./ModeTreatment.c
- History
- Source
- Diff
./ModeTreatment.c
… 3 more files in changeset.

11:00 am

Sean Nash

More
Re: HD-DENBUG-298-1
commented on review

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we foll...

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we follow that design pattern for this confirmation?

10:25 am