OperationModes.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

HD-DENBUG-298_User Unable TO Deliver Saline Bolus During Alarm Conditions Where The Blood Pump IS Recirculating
HD-DENBUG-298_User Unable TO Deliver Saline Bolus During Alarm Conditions Where The Blood Pump IS Recirculating
DEN-17273 updated the code from staging

HD-DEN-17273_Release 21 Cpp Check Fix P1B Staging
HD-DEN-17273_Release 21 Cpp Check Fix P1B Staging
HD-DEN-17273_Release 21 Cpp Check Fix Staging
HD-DEN-17273_Release 21 Cpp Check Fix Staging
DENBUG-298 updated the code from staging

  1. … 19 more files in changeset.
HD-DENBUG-298_User Unable TO Deliver Saline P1B Staging
HD-DENBUG-298_User Unable TO Deliver Saline P1B Staging
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Bad practice to have two calls to same function here. Possible that 2nd call will return different result. Should call function once to assign value to a local var prior to if statement and then re...

Bad practice to have two calls to same function here. Possible that 2nd call will return different result.
Should call function once to assign value to a local var prior to if statement and then reference the local var in the if statement.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes. I think we should have these events to information.

Yes. I think we should have these events to information.

Are these permanent?

Are these permanent?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Add comment explaining what we're doing here.

Add comment explaining what we're doing here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Moved it to OperationModes

Moved it to OperationModes

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we foll...

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we follow that design pattern for this confirmation?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.