Activity dgfirmware/firmware/App/Modes/ModeFill.c

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	11
Last Commit:	18 Sep 23
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Friday 15 Sep 2023

4:38 pm

Dara Navaei

More
8ee0169
changed 3 files
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more DG-DEN-15791-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 2 more files in changeset.

Wednesday 13 Sep 2023

9:52 am

James Walter Taylor <jtaylor@diality.com>

More
35a1f7d
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more DG-DEN-16314-1

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

On Dara's advice, ifdef'ed code for fill state treatment recovery

- -17
- +12
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Tuesday 12 Sep 2023

10:55 am

James Walter Taylor <jtaylor@diality.com>

More
9aacc7b
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more DG-DEN-16314-1

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reset timers when doing a test recover state, or returning from a (reset) fault condition.

- -3
- +5
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Friday 08 Sep 2023

5:23 pm

James Walter Taylor <jtaylor@diality.com>

More
482a741
changed 2 files
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more DG-DEN-16314-1

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Reintroduced reservoir data structure change.

Corrected the setModeFillStateTransition semantics.

- -2
- +3
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 1 more file in changeset.

1:27 pm

James Walter Taylor <jtaylor@diality.com>

More
c2684b5
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more DG-DEN-16314-1

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Corrected spacing in the file per CR comments

- -1
- +3
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

10:42 am

James Walter Taylor <jtaylor@diality.com>

More
66c487d
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more DG-DEN-16314-1

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Follow up for changes, simplifications suggested by Sean.

- -50
- +24
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Thursday 07 Sep 2023

3:34 pm

James Walter Taylor <jtaylor@diality.com>

More
6e76184
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more DG-DEN-16314-1

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Updated headers

- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

3:27 pm

James Walter Taylor <jtaylor@diality.com>

More
ade9db1
changed 2 files
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more DG-DEN-16314-1

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

fill time allowance for time spent in pause state

Cleared fill timer on transition to generate

Added removed unused (and uninitialized) variables from broadcast data structure.

- -2
- +38
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 1 more file in changeset.

Friday 01 Sep 2023

4:38 pm

James Walter Taylor <jtaylor@diality.com>

More
631df81
changed 2 files
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more DG-DEN-16314-1

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Initial changes for alarm 206 timer

- -21
- +23
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 1 more file in changeset.

Wednesday 30 Aug 2023

3:48 pm

Dara Navaei

More
16c0f81
changed 6 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 5 more files in changeset.

Friday 25 Aug 2023

2:50 pm

Vinayakam Mani

More
6e49f49
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more DG-DEN-16093-1

DEN-16093 fixed code review comments

- -2
- +5
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

1:21 pm

Vinayakam Mani

More
ed367cb
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more DG-DEN-16093-1

DEN-16093-Increased conductivity percentage check and time out values

- -3
- +3
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

1:06 pm

Vinayakam Mani

More
4b528a5
changed 4 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more DG-DEN-16093-1

take latest changes from staging

- -5
- +13
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 3 more files in changeset.

Wednesday 23 Aug 2023

10:21 am

Vinayakam Mani

More
2de5552
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more DG-DEN-16093-1

DEN-16093-changed prime Max time and conductivity poercent check

- -5
- +5
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Friday 18 Aug 2023

1:50 pm

Dara Navaei

More
b766ff8
changed 3 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 75 more DG-DEN-16093-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 2 more files in changeset.

1:45 pm

Dara Navaei

More
5bf4b57
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more DG-DEN-16250-1

DEN-16250 updated doxygen comment

- -2
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Thursday 17 Aug 2023

2:50 pm

Dara Navaei

More
bcd5068
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more DG-DEN-16250-1

DEN-15250 addressed alarm 207

- -5
- +13
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

9:48 am

Dara Navaei

More
2c23724
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more DG-DEN-16250-1

DEN-16250 added the FMP check flag to state transition function in mode fill

- -1
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Wednesday 16 Aug 2023

11:30 am

Dara Navaei

More
7f64bdb
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

10:28 am

Dara Navaei

More
d3e1ad2
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more DG-DEN-16215-1

DEN-16215 addressed the code review comments

- -0
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

10:20 am

Dara Navaei

More
6919275
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more DG-DEN-16215-1

DEN-16215 removed the start state from mode fill

- -8
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Thursday 10 Aug 2023

8:36 am

Dara Navaei

More
1a21988
changed 9 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 84 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 8 more files in changeset.

8:15 am

Michael Garthwaite

More
cfcb924
changed 2 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more

Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

- -22
- +3
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 1 more file in changeset.

Wednesday 09 Aug 2023

5:36 pm

Dara Navaei

More
8ebab81
changed 8 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 7 more files in changeset.

4:44 pm

Dara Navaei

More
56b1e41
changed 6 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more DG-DEN-16125-1

DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed is called

- -2
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 5 more files in changeset.

1:33 pm

Dara Navaei

More
e7456f2
changed 3 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more DG-DEN-16125-1

DEN-15125 addressed the compiler warnings

- -19
- +0
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 2 more files in changeset.

Tuesday 08 Aug 2023

1:37 pm

Michael Garthwaite

More
8a9d78a
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more DG-DEN-15634-1

DEN-15634: code review comments

- -1
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Monday 07 Aug 2023

4:13 pm

Michael Garthwaite

More
7295613
changed 6 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more DG-DEN-15634-1

DEN-15634: implemented bad fill signal on fill and drain modes. Implemented drain mode broadcast

- -1
- +3
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 5 more files in changeset.

Wednesday 26 Jul 2023

11:39 am

Dara Navaei

More
9b8889b
changed 12 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 92 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 11 more files in changeset.

Monday 24 Jul 2023

3:07 pm

Dara Navaei

More
f62ad14
changed 2 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more DG-DEN-15921-1

DEN-15921 changed the active cool to transition to cancel water path instead of basic path when caps are not on

- -2
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 1 more file in changeset.

ModeFill.c

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

James Walter Taylor <jtaylor@diality.com>

James Walter Taylor <jtaylor@diality.com>

James Walter Taylor <jtaylor@diality.com>

James Walter Taylor <jtaylor@diality.com>

James Walter Taylor <jtaylor@diality.com>

James Walter Taylor <jtaylor@diality.com>

James Walter Taylor <jtaylor@diality.com>

James Walter Taylor <jtaylor@diality.com>

Dara Navaei

Vinayakam Mani

Vinayakam Mani

Vinayakam Mani

Vinayakam Mani

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Michael Garthwaite

Dara Navaei

Dara Navaei

Dara Navaei

Michael Garthwaite

Michael Garthwaite

Dara Navaei

Dara Navaei