ro-firmware / firmware / App / Controllers

ROPump.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 04 Sep
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 04 Sep
1:19 pm

Raghu Kallala

LDT-1809 Resolved conflicts while merging staging

Options
    • -16
    • +35
    ./ROPump.c
  2. … 3 more files in changeset.
Wednesday 03 Sep
9:44 am

Michael Garthwaite

LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm cnt

Options
    • -11
    • +11
    ./ROPump.c
  2. … 4 more files in changeset.
8:49 am

Michael Garthwaite

LDT-1242: reverted RO controller publishing to no longer contain controller debug data

Options
    • -5
    • +5
    ./ROPump.c
Friday 29 Aug
8:56 am

Michael Garthwaite

LDT-1242: reverted flow control output for develop builds as pwm output requires tuning

Options
    • -7
    • +9
    ./ROPump.c
Thursday 28 Aug
9:30 am

Michael Garthwaite

LDT-1242: converted RO flow control back to outputting PWM percentages instead of target mL/min.

Options
    • -13
    • +12
    ./ROPump.c
8:51 am

Michael Garthwaite

LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

Options
    • -2
    • +2
    ./ROPump.c
  2. … 5 more files in changeset.
Wednesday 27 Aug
2:54 pm

Raghu Kallala

Fixed indentation and review comments

Options
    • -18
    • +18
    ./ROPump.c
Tuesday 26 Aug
2:54 pm

Raghu Kallala

fixed review comments

Options
    • -30
    • +53
    ./ROPump.c
  2. … 2 more files in changeset.
10:37 am

Raghu Kallala

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Options
    • -100
    • +62
    ./ROPump.c
  2. … 5 more files in changeset.
Monday 25 Aug
12:40 pm

Michael Garthwaite

LDT-566: updated RO pwm flow curve from linear to logarithmic.

Options
    • -6
    • +7
    ./ROPump.c
Wednesday 20 Aug
8:59 am

Raghu Kallala

removed commented code per review comments

Options
    • -1
    • +0
    ./ROPump.c
Tuesday 19 Aug
10:14 am

Raghu Kallala

declared result at the top of the scope for test functions

Options
    • -3
    • +6
    ./ROPump.c
Thursday 14 Aug
1:08 pm

Michael Garthwaite

LDT-566: reverted publishing change for fine tuning.

Options
    • -5
    • +5
    ./ROPump.c
1:07 pm

Michael Garthwaite

LDT-566: fixed RO Pump publishing to no longer have debug data for PI control

Options
    • -5
    • +5
    ./ROPump.c
11:11 am

Michael Garthwaite

LDT-2003: 1st stage of flow control. still wip. moved event from bad crc error to all faults.

Options
    • -18
    • +35
    ./ROPump.c
  2. … 2 more files in changeset.
Wednesday 13 Aug
3:00 pm

Raghu Kallala

Removed commented code lines

Options
    • -2
    • +0
    ./ROPump.c
1:46 pm

Raghu Kallala

Addressed review comments and modified the override behavior as discussed.

Options
    • -174
    • +161
    ./ROPump.c
  2. … 2 more files in changeset.
Monday 11 Aug
10:15 am

Raghu Kallala

Addressed review comments to remove blank lines

Options
    • -6
    • +0
    ./ROPump.c
Friday 08 Aug
11:53 am

Raghu Kallala

Fix for RO Pump override set and reset.

Options
    • -75
    • +239
    ./ROPump.c
Friday 01 Aug
3:56 pm

Michael Garthwaite

LDT-566: code review comments

Options
    • -3
    • +0
    ./ROPump.c
  2. … 13 more files in changeset.
12:08 pm

Michael Garthwaite

LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

Options
    • -4
    • +6
    ./ROPump.c
  2. … 7 more files in changeset.
Thursday 31 Jul
11:51 am

Michael Garthwaite

LDT-566: fixed macro calls

Options
    • -4
    • +4
    ./ROPump.c
11:49 am

Michael Garthwaite

LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

Options
    • -7
    • +7
    ./ROPump.c
  2. … 5 more files in changeset.
Wednesday 30 Jul
1:30 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -18
    • +20
    ./ROPump.c
  2. … 19 more files in changeset.
Tuesday 29 Jul
12:15 pm

Michael Garthwaite

LDT-566: FP Safety shutdown override. fixed includes.

Options
    • -3
    • +2
    ./ROPump.c
  2. … 12 more files in changeset.
9:58 am

Michael Garthwaite

WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

Options
    • -1
    • +2
    ./ROPump.c
  2. … 39 more files in changeset.
Thursday 17 Jul
3:47 pm

Michael Garthwaite

LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure sensors. Fixed Pre-Generate mode rushing through sub states.

Options
    • -2
    • +2
    ./ROPump.c
  2. … 12 more files in changeset.
Tuesday 15 Jul
4:31 pm

Michael Garthwaite

LDT-566: Implemented hard stop commands for water pumps. Added valve actuation for RO recovery settings in gen permeate, set to med.

Options
    • -0
    • +19
    ./ROPump.c
  2. … 7 more files in changeset.
3:54 pm

Michael Garthwaite

LDT-566: transitioning to standby mode and fault mode will now shut off pumps and close valves. updates in naming. fixed pre-gen transitioning. removed some checks for when gen water request it received.

Options
    • -59
    • +88
    ./ROPump.c
  2. … 13 more files in changeset.
Wednesday 09 Jul
2:14 pm

Michael Garthwaite

LDT-566: generate water modes both defeatured and ro featured

Options
    • -2
    • +28
    ./ROPump.c
  2. … 28 more files in changeset.