td-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 12
Total Committers: 11
Last Commit: 28 Apr
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
5 mins ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

6 mins ago

Sean Nash

Remove extra space before function name.

Remove extra space before function name.

6 mins ago

Sean Nash

This is not a Dialin message, so move up above all of these "test" functions.

This is not a Dialin message, so move up above all of these "test" functions.

7 mins ago

Sean Nash

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate dox...

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

13 mins ago

Raghu Kallala

As the fw haven't requested the gen dialysate it is expected to be in pre-gen mode

As the fw haven't requested the gen dialysate it is expected to be in pre-gen mode

42 mins ago

Michael Garthwaite

1 hr ago

Vinayakam Mani

Do we have a return confirmation that the command is accepted by DD?

Do we have a return confirmation that the command is accepted by DD?

1 hr ago

Vinayakam Mani

Is the UF rate unit in ml/min (instead of hr.)?

Is the UF rate unit in ml/min (instead of hr.)?

1 hr ago

Vinayakam Mani

Are we assuming the sub mode return is pre-gen sub mode always?

Are we assuming the sub mode return is pre-gen sub mode always?

2 hrs ago

Michael Garthwaite

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

2 hrs ago

Michael Garthwaite

comment still needed?

comment still needed?

2 hrs ago

Michael Garthwaite

Wednesday 29 Apr
2:01 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
10:57 am

Raghu Kallala

10:44 am

Vinayakam Mani

9:57 am

Sean Nash

Keep 2 blank lines above the banner below.

Keep 2 blank lines above the banner below.

9:56 am

Sean Nash

Is this still needed?

Is this still needed?

9:56 am

Sean Nash

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

9:49 am

Sean Nash

Keep 2 blank lines above the test support functions banner.

Keep 2 blank lines above the test support functions banner.

9:47 am

Sean Nash

Not sure why you are making changes to this function. This function handles message from UI to pause or resume ultrafiltration. This is not a treatment parameter edit message, so I don't think it's...

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

9:43 am

Sean Nash

No longer needed?

No longer needed?

9:42 am

Sean Nash

9:42 am

Sean Nash

Tuesday 28 Apr
6:13 pm

Sean Nash

2:31 pm

Sean Nash

???

???

2:30 pm

Sean Nash

Do we need a parameter for confirmation?

Do we need a parameter for confirmation?

9:23 am

Vendor - TEL - Praneeth Bunne

LDT-1886: Addressed code review comments

Options
    • -8
    • +9
    ./ModePostTreat.c
    • -9
    • +15
    ./ModePreTreat.c
  3. … 1 more file in changeset.
Sunday 26 Apr
3:41 pm

Sean Nash

It looks like you deleted it instead of fixing it.

It looks like you deleted it instead of fixing it.

3:40 pm

Sean Nash

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

3:39 pm

Sean Nash

Need to check heparin bolus volume > 0 too.

Need to check heparin bolus volume > 0 too.