td-firmware / firmware / App / Modes

StateTxBloodPrime.c

Clone Tools

Stats

Commits this week: 5
Total Committers: 4
Last Commit: 13 Mar
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 17 Mar
2:15 pm

Sean Nash

9:58 am

Sean Nash

Wrong place.

Wrong place.

9:57 am

Sean Nash

I'll drop by and we can set properties together.

I'll drop by and we can set properties together.

Monday 16 Mar
5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Sorry, Updated

Sorry, Updated

5:21 pm

Vendor - TEL - Varshini Nagabooshanam

Updated, if this is wrong then I need your help

Updated, if this is wrong then I need your help

4:33 pm

Sean Nash

Match properties from Denali where you can. The priorities should both be HIGH. The rank for the warning should be a higher number. The alarm should be TRUE for no resume and no rinseback. So, I kn...

Match properties from Denali where you can. The priorities should both be HIGH. The rank for the warning should be a higher number. The alarm should be TRUE for no resume and no rinseback. So, I know these properties aren't correct.
One thing I don't think we should copy from Denali though - I think the warning should not be TRUE for the STOP property so that we stay in blood prime state.

4:31 pm

Sean Nash

Add a blank line after declaration.

Add a blank line after declaration.

4:30 pm

Sean Nash

I think we should just have == here so that we only warn them once.

I think we should just have == here so that we only warn them once.

4:23 pm

Sean Nash

Don't mention alarms in brief. Add a details line for Alarms for the alarm(s) that the function might trigger (look for other functions that do this for example).

Don't mention alarms in brief. Add a details line for Alarms for the alarm(s) that the function might trigger (look for other functions that do this for example).

4:22 pm

Sean Nash

Name in brief doesn't match function name.

Name in brief doesn't match function name.

4:19 pm

Sean Nash

I don't understand what you did here. The '*' characters were in the right place before. Do we want to keep the stroke code changes? Do we know where they came from?

I don't understand what you did here. The '*' characters were in the right place before. Do we want to keep the stroke code changes? Do we know where they came from?

2:33 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:27 am

Sean Nash

I'm not seeing where alarms get triggered?

I'm not seeing where alarms get triggered?

10:14 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:13 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:13 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:13 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:13 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:13 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:13 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:13 am

Vendor - TEL - Varshini Nagabooshanam

Aligned

Aligned

Friday 13 Mar
2:57 pm

Sean Nash

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 ...

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 minute (60 secs) and we need to alarm more severely when countdown reaches 0 secs.

If you make the 2 times static (not local here), you can call a monitor function from exec and do the calculations for the times and trigger alarms in the monitor function. Then, here in publish function, you would just publish the static times (no need to calculate because it's already done all the time).

2:51 pm

Sean Nash

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

2:43 pm

Sean Nash

Use MS_PER_SECOND (in Common.h I think) instead of 1000. Also, make sure elapsedSec does not exceed timeout (300) so countdown doesn't go negative.

Use MS_PER_SECOND (in Common.h I think) instead of 1000.
Also, make sure elapsedSec does not exceed timeout (300) so countdown doesn't go negative.

2:39 pm

Sean Nash

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

2:35 pm

Sean Nash

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

2:35 pm

Sean Nash

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

2:34 pm

Sean Nash

I think we can initialize to zero here. We haven't paused yet.

I think we can initialize to zero here. We haven't paused yet.