td-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 4
Total Committers: 9
Last Commit: 13 Mar
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Mar
9:12 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:12 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

Tuesday 17 Mar
9:46 pm

Sean Nash

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

9:44 pm

Sean Nash

I was thinking that comment should go above the first if statement.

I was thinking that comment should go above the first if statement.

3:05 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:56 pm

Sean Nash

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below: #define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall con...

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

2:56 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:53 pm

Sean Nash

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:50 pm

Sean Nash

Should probably initialize your new stall counter variable.

Should probably initialize your new stall counter variable.

2:15 pm

Sean Nash

2:11 pm

Vendor - TEL - Varshini Nagabooshanam

Sean Nash I need your help for writing this Alarm properties.

Sean Nash I need your help for writing this Alarm properties.

2:03 pm

Sean Nash

9:58 am

Sean Nash

Wrong place.

Wrong place.

9:57 am

Sean Nash

I'll drop by and we can set properties together.

I'll drop by and we can set properties together.

Monday 16 Mar
5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

5:22 pm

Vendor - TEL - Varshini Nagabooshanam

Sorry, Updated

Sorry, Updated

5:21 pm

Vendor - TEL - Varshini Nagabooshanam

Updated, if this is wrong then I need your help

Updated, if this is wrong then I need your help

4:33 pm

Sean Nash

Match properties from Denali where you can. The priorities should both be HIGH. The rank for the warning should be a higher number. The alarm should be TRUE for no resume and no rinseback. So, I kn...

Match properties from Denali where you can. The priorities should both be HIGH. The rank for the warning should be a higher number. The alarm should be TRUE for no resume and no rinseback. So, I know these properties aren't correct.
One thing I don't think we should copy from Denali though - I think the warning should not be TRUE for the STOP property so that we stay in blood prime state.

4:31 pm

Sean Nash

Add a blank line after declaration.

Add a blank line after declaration.

4:30 pm

Sean Nash

I think we should just have == here so that we only warn them once.

I think we should just have == here so that we only warn them once.

4:23 pm

Sean Nash

Don't mention alarms in brief. Add a details line for Alarms for the alarm(s) that the function might trigger (look for other functions that do this for example).

Don't mention alarms in brief. Add a details line for Alarms for the alarm(s) that the function might trigger (look for other functions that do this for example).

4:22 pm

Sean Nash

Name in brief doesn't match function name.

Name in brief doesn't match function name.

4:19 pm

Sean Nash

I don't understand what you did here. The '*' characters were in the right place before. Do we want to keep the stroke code changes? Do we know where they came from?

I don't understand what you did here. The '*' characters were in the right place before. Do we want to keep the stroke code changes? Do we know where they came from?

2:33 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:27 am

Sean Nash

I'm not seeing where alarms get triggered?

I'm not seeing where alarms get triggered?

10:14 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:13 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:13 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added