td-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 3
Total Committers: 6
Last Commit: 29 Jan
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Feb
1:02 pm

Vendor - TEL - Varshini Nagabooshanam

Monday 02 Feb
4:44 pm

Vendor - TEL - Sameer Poyil

input parameter not updated

input parameter not updated

4:44 pm

Vendor - TEL - Sameer Poyil

input parameter is not updated

input parameter is not updated

4:40 pm

Vendor - TEL - Sameer Poyil

input and output is not updated properly

input and output is not updated properly

4:33 pm

Vendor - TEL - Sameer Poyil

structure packing required

structure packing required

4:26 pm

Vendor - TEL - Jashwant Gantyada

Thursday 29 Jan
2:06 pm

Sean Nash

2:02 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:53 pm

Sean Nash

Please keep local declarations together up top.

Please keep local declarations together up top.

1:49 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:49 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:06 pm

Sean Nash

I would make another local variable (BOOL) above and set it per trinary operation and then pass the BOOL to the function. I think we want to avoid complex logic or function calls as a function para...

I would make another local variable (BOOL) above and set it per trinary operation and then pass the BOOL to the function.
I think we want to avoid complex logic or function calls as a function parameter per our coding standards.

1:03 pm

Sean Nash

Remove blank line.

Remove blank line.

12:05 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

12:04 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

12:04 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

12:04 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

12:04 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

12:04 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

12:04 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

12:02 pm

Vendor - TEL - Jashwant Gantyada

done

done

12:00 pm

Vendor - TEL - Jashwant Gantyada

LDT-2749 Addressed code review comments

Options
    • -1
    • +1
    ./Messaging.c
  2. … 2 more files in changeset.
11:02 am

Sean Nash

Not an override command. We want to update bubbleDetectionEnabled[] for the venous sensor (index 0) to the given T/F state.

Not an override command. We want to update bubbleDetectionEnabled[] for the venous sensor (index 0) to the given T/F state.

11:00 am

Sean Nash

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM

10:58 am

Sean Nash

Check msg payload length, set result to TRUE and set enable only if length is correct.

Check msg payload length, set result to TRUE and set enable only if length is correct.

10:56 am

Sean Nash

Update function name to match actual name. Remove references to standby mode - function should work in any mode.

Update function name to match actual name. Remove references to standby mode - function should work in any mode.

10:55 am

Sean Nash

Not needed. Remove.

Not needed. Remove.

10:55 am

Sean Nash

This is not necessary - bubbleDetectionEnabled[] above takes care of this. Remove.

This is not necessary - bubbleDetectionEnabled[] above takes care of this. Remove.

10:53 am

Sean Nash

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM?

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM?

10:52 am

Sean Nash

testEnableVenousBubbleAlarm?

testEnableVenousBubbleAlarm?