td-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 1
Total Committers: 6
Last Commit: 13:31
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
10 hrs ago

Varshini Nagabooshanam <ven.vnagabooshanam@diality.com>

LDT-3126-blood-prime-td

Options
    • -2
    • +12
    ./Valves.h
  2. … 3 more files in changeset.
Monday 22 Dec
8:48 am

Raghu Kallala

Friday 19 Dec
1:57 pm

Dara Navaei

12:16 pm

Vendor - TEL - Sameer Poyil and Sean Nash

Thursday 18 Dec
3:32 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
3:08 pm

Dara Navaei

We tend to initialize the local variables as a standard practice.

We tend to initialize the local variables as a standard practice.

2:54 pm

Sean Nash

These don't need to be initialized to zero.

These don't need to be initialized to zero.

Wednesday 17 Dec
11:07 am

Dara Navaei

Done

Done

11:06 am

Dara Navaei

Done

Done

11:05 am

Dara Navaei

Done

Done

10:49 am

Dara Navaei

Done

Done

10:48 am

Dara Navaei

Done

Done

Tuesday 16 Dec
2:55 pm

Dara Navaei

Done.

Done.

2:53 pm

Dara Navaei

No. It is permanent, I would like to know the value for the homing.

No. It is permanent, I would like to know the value for the homing.

2:17 pm

Sean Nash

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

2:15 pm

Sean Nash

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

2:13 pm

Sean Nash

Declarations should be at top of scope.

Declarations should be at top of scope.

2:13 pm

Sean Nash

Is this temporary?

Is this temporary?

2:12 pm

Sean Nash

2:08 pm

Vendor - TEL - Varshini Nagabooshanam

Updated.

Updated.

2:07 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, we need to

Yes, we need to

2:07 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:44 pm

Sean Nash

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

1:43 pm

Sean Nash

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

1:36 pm

Sean Nash

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

1:32 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, I deleted.

Yes, I deleted.

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:01 pm

Dara Navaei

Done

Done