Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

lower? and change the D98 level sensor comment as well.

lower? and change the D98 level sensor comment as well.

Remove empty line

Remove empty line

Space before LVL_STATE_LOW

Space before LVL_STATE_LOW

space inside array index.

space inside array index.

Space inside parenthesis.

Space inside parenthesis.

Change this to LEVEL_T enum.

Change this to LEVEL_T enum.

Is this macro still being used? if not, delete it.

Is this macro still being used? if not, delete it.

LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine ...

control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine or not

This code looks very similar to bicarb code above. Do we really need separate handling?

This code looks very similar to bicarb code above. Do we really need separate handling?

Remove extra blank line.

Remove extra blank line.

Add unit of measure to definition name (e.g. _PSI). Should be done for all definitions w/ a unit of measure to prevent unit errors.

Add unit of measure to definition name (e.g. _PSI). Should be done for all definitions w/ a unit of measure to prevent unit errors.

LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1:
LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1:
fixed

fixed

Align the comments.

Align the comments.

LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Its static function and not used by external API to pass the wrong id.

Its static function and not used by external API to pass the wrong id.