dd-firmware

firmware

Clone Tools

Stats

Commits this week: 26
Total Committers: 15
Last Commit: 24 Feb
Commits this week: 26

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 24 Feb
11:32 pm

Vendor - TEL - Sameer Poyil

LDT-3219 removing D3 open in standby mode

Options
    • -3
    • +0
    ./App/Modes/ModeStandby.c
2:51 pm

Vendor - TEL - Sameer Poyil

is it ok to make a test config ? its a feature , it can be configured run time ?

is it ok to make a test config ? its a feature , it can be configured run time ?

11:55 am

Vendor - TEL - Jashwant Gantyada

10:39 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
10:38 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Controllers/RinsePump.c
    • -2
    • +2
    ./App/Controllers/RinsePump.h
    • -2
    • +2
    ./App/Controllers/Valves.c
    • -2
    • +2
    ./App/Drivers/FluidPump.c
    • -2
    • +2
    ./App/Drivers/GPIO.c
    • -2
    • +2
    ./App/Drivers/GPIO.h
    • -2
    • +2
    ./App/Modes/FPModes/StateFlushConcentrate.c
    • -2
    • +2
    ./App/Monitors/Level.c
    • -2
    • +2
    ./App/Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./App/Services/FpgaDD.c
    • -3
    • +3
    ./App/Services/FpgaDD.h
    • -2
    • +2
    ./App/Tasks/TaskPriority.c
10:35 am

Raghu Kallala , Vinayakam Mani and Sean Nash

9:34 am

Sean Nash

8:35 am

Raghu Kallala

LDT-3344 added code for concentrate flush recovery valve actuation per HW type.

Options
    • -3
    • +13
    ./App/Modes/FPModes/StateFlushConcentrate.c
Monday 23 Feb
6:29 pm

Vendor - TEL - Sameer Poyil

need a brief description about this feature and how it is implemented/logic/math etc - also comment on the previous logic

need a brief description about this feature and how it is implemented/logic/math etc - also comment on the previous logic

6:27 pm

Vendor - TEL - Sameer Poyil

its a reverse logic - is it OK to make positive instead of not defined ?

its a reverse logic - is it OK to make positive instead of not defined ?

1:37 pm

Raghu Kallala

LDT-3344 resolved merge conflicts with staging

Options
    • -128
    • +149
    ./App/Controllers/Valves.c
    • -3
    • +3
    ./App/Monitors/Level.c
    • -3
    • +6
    ./App/Services/AlarmMgmtSWFaults.h
    • -64
    • +72
    ./App/Services/FpgaDD.c
    • -8
    • +8
    ./App/Services/FpgaDD.h
1:18 pm

Vendor - TEL - Jashwant Gantyada

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
4:00 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Friday 20 Feb
5:07 pm

Dara Navaei

3:12 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
3:12 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Controllers/Valves.h
    • -2
    • +2
    ./App/Drivers/BloodLeakDriver.h
2:46 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

2:41 pm

Sean Nash

2:19 pm

Vendor - TEL - Sameer Poyil

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

2:17 pm

Vendor - TEL - Sameer Poyil

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

1:42 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:42 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

1:41 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:41 pm

Vendor - TEL - Jashwant Gantyada

LDT-3344 addressed code review comments

Options
    • -21
    • +1
    ./App/Controllers/RinsePump.c
    • -19
    • +9
    ./App/Services/FpgaDD.c
    • -9
    • +8
    ./App/Services/FpgaDD.h
12:50 pm

Raghu Kallala

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active

11:03 am

Sean Nash

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6). We still need test configs for beta 1.0 stuff and non-fpga differences. We can use DD fpga ID # here in this macro instead of t...

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6).
We still need test configs for beta 1.0 stuff and non-fpga differences.
We can use DD fpga ID # here in this macro instead of test config.
Since this is all temporary, I'm not that concerned about how we do this so long as it works.

10:22 am

Sean Nash

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff. I agree, but didn't comm...

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff.
I agree, but didn't comment on it because it's all temporary anyway.

9:59 am

Sean Nash

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

9:46 am

Sean Nash

Move this up to public definitions section.

Move this up to public definitions section.

9:41 am

Sean Nash

These don't need to be initialized.

These don't need to be initialized.