dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Align the comments.

Align the comments.

LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Its static function and not used by external API to pass the wrong id.

Its static function and not used by external API to pass the wrong id.

0.0F is made by Sean.

0.0F is made by Sean.

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

COMM_BUFFER_OUT_CAN_FP_BROADCAST sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

COMM_BUFFER_OUT_CAN_FP_BROADCAST

sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

Do we know which channel this event will be sent on?

Do we know which channel this event will be sent on?

nope. removed.

nope. removed.

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

Same comment applies here (removing resetPIController).

Same comment applies here (removing resetPIController).