td-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 6
Total Committers: 9
Last Commit: 13 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 13 Mar
2:57 pm

Sean Nash

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 ...

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 minute (60 secs) and we need to alarm more severely when countdown reaches 0 secs.

If you make the 2 times static (not local here), you can call a monitor function from exec and do the calculations for the times and trigger alarms in the monitor function. Then, here in publish function, you would just publish the static times (no need to calculate because it's already done all the time).

2:51 pm

Sean Nash

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

2:43 pm

Sean Nash

Use MS_PER_SECOND (in Common.h I think) instead of 1000. Also, make sure elapsedSec does not exceed timeout (300) so countdown doesn't go negative.

Use MS_PER_SECOND (in Common.h I think) instead of 1000.
Also, make sure elapsedSec does not exceed timeout (300) so countdown doesn't go negative.

2:39 pm

Sean Nash

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

2:35 pm

Sean Nash

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

2:35 pm

Sean Nash

Assign bloodPrimeStartMS here to mark start of pause.

Assign bloodPrimeStartMS here to mark start of pause.

2:34 pm

Sean Nash

I think we can initialize to zero here. We haven't paused yet.

I think we can initialize to zero here. We haven't paused yet.

2:33 pm

Sean Nash

Align with others (after U32).

Align with others (after U32).

Thursday 12 Mar
4:32 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
4:23 pm

Vendor - TEL - Varshini Nagabooshanam

4:21 pm

Vendor - TEL - Sameer Poyil and Sean Nash

4:21 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
Tuesday 10 Mar
3:00 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./StateTxBloodPrime.c
    • -1
    • +1
    ./StateTxBloodPrime.h
  3. … 1 more file in changeset.
2:08 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' into LDT-3126-blood-prime-td

Options
    • -2
    • +2
    ./StateTxBloodPrime.c
11:08 am

Vendor - TEL - Varshini Nagabooshanam

LDT-3126-blood-prime-td

Options
    • -1
    • +1
    ./StateTxBloodPrime.c
Thursday 05 Mar
1:49 pm

Sean Nash

blank line before return.

blank line before return.

1:49 pm

Sean Nash

Blank line after declarations.

Blank line after declarations.

Tuesday 03 Mar
4:42 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

4:42 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

4:41 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-3126-blood-prime-td

Options
    • -1
    • +2
    ./StateTxBloodPrime.c
4:35 pm

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

4:35 pm

Sean Nash

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we shoul...

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we should reject it because we're not in the right state.
if ( ( MODE_TREA == getCurrentOperationMode() ) && ( TREATMENT_BLOOD_PRIME_STATE == getTreatmentState() ) )

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, Updated

Yes, Updated

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Replaced

Replaced

2:54 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-3126-blood-prime-td

Options
    • -16
    • +16
    ./StateTxBloodPrime.c
2:11 pm

Sean Nash

This should be invalid state (or something like that).

This should be invalid state (or something like that).

2:11 pm

Sean Nash

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU...

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU32TreatmentParamUpperRangeLimit() functions from the TxParams service.

2:08 pm

Sean Nash

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.