dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

Please check with TD, I have seen one of the develop branch this populated in pre gen and gen.

why TODO?

why TODO?

Do we need to close D64 as well?

Do we need to close D64 as well?

Delete the commented line

Delete the commented line

handleBicarbChamberInitiateSupply?

handleBicarbChamberInitiateSupply?

Update this.

Update this.

Remove this comment.

Remove this comment.

Update Inputs and Outputs throughout the file.

Update Inputs and Outputs throughout the file.

Do we need this?

Do we need this?

when are we closing D64 valve? handle the same in else block as well.

when are we closing D64 valve? handle the same in else block as well.

Can this be assigned during declaration time?

Can this be assigned during declaration time?

are we using these?

are we using these?

Can we use one macro (instead of three) for the D66 persistence?

Can we use one macro (instead of three) for the D66 persistence?

The difference between the actual pressure measured at bicart assembly and the measured D66 pressure based on the placement of the sensor.

The difference between the actual pressure measured at bicart assembly and the measured D66 pressure based on the placement of the sensor.

Dry bicart data publish in the comment.

Dry bicart data publish in the comment.

fix the typo in 'persistence' across the file.

fix the typo in 'persistence' across the file.

This function is not checking the level anymore and may be move the functionality at end of fill water end state and transition to next chamber fill state directly,

This function is not checking the level anymore and may be move the functionality at end of fill water end state and transition to next chamber fill state directly,

Check pressure limit.

Check pressure limit.

Does this supposed to be 14 or 17 PSI (based on manifold) for B2.1 hardware?

Does this supposed to be 14 or 17 PSI (based on manifold) for B2.1 hardware?

Is this code updated for B2.1 fill implementation?

Is this code updated for B2.1 fill implementation?

Update Inputs and outputs.

Update Inputs and outputs.

fix the typo.

fix the typo.

declare a local variable to get these function values and use the variables here?

declare a local variable to get these function values and use the variables here?

remove blank space before =

remove blank space before =

Can we split the functions into two files: 1) DryBicart.c/h - Manages drybicart fill, supply, drain & depressurizing states and 2) MixingControl: for acid/bicarb open/close loop functionality?

Can we split the functions into two files: 1) DryBicart.c/h - Manages drybicart fill, supply, drain & depressurizing states and 2) MixingControl: for acid/bicarb open/close loop functionality?

Same as above.

Same as above.