td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 47
Total Committers: 13
Last Commit: 06 Mar
Commits this week: 47

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Mar
3:26 pm

Dara Navaei

2:27 pm

Sean Nash

Should this event be TD_EVENT_AIR_TRAP_FILL?

Should this event be TD_EVENT_AIR_TRAP_FILL?

2:22 pm

Sean Nash and Vendor - TEL - Jashwant Gantyada

2:02 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

1:58 pm

Sean Nash and Vendor - TEL - Jashwant Gantyada

1:56 pm

Sean Nash

I don't think we need to call setPressureLimitsToOuterBounds() either. The signal function will indirectly cause that function to be called later.

I don't think we need to call setPressureLimitsToOuterBounds() either. The signal function will indirectly cause that function to be called later.

1:18 pm

Dara Navaei

11:41 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

11:23 am

Dara Navaei

LDT-3599 added a new #define to disable the UI related alarms until the UI board is ready

Options
    • -1
    • +1
    ./Services/SystemCommTD.c
    • -0
    • +1
    ./TDCommon.h
    • -1
    • +1
    ./Tasks/TaskBG.c
11:10 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3599_(TD) UI Comm alarms trigger after TD power-on or reset
LEAHI-TD-FIRMWARE-LDT-3599_(TD) UI Comm alarms trigger after TD power-on or reset
9:55 am

Sean Nash

I think we should just call signalInitiatePressureStabilization( USE_NORMAL_STABILIZATION_PERIOD );

I think we should just call signalInitiatePressureStabilization( USE_NORMAL_STABILIZATION_PERIOD );

9:50 am

Sean Nash

Thursday 05 Mar
3:47 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
1:49 pm

Sean Nash

blank line before return.

blank line before return.

1:49 pm

Sean Nash

Blank line after declarations.

Blank line after declarations.

1:16 pm

Sean Nash

Wednesday 04 Mar
8:22 pm

Vendor - TEL - Sameer Poyil

9:40 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

4:01 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
Tuesday 03 Mar
4:44 pm

Sean Nash

4:42 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

4:42 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

4:35 pm

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

4:35 pm

Sean Nash

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we shoul...

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we should reject it because we're not in the right state.
if ( ( MODE_TREA == getCurrentOperationMode() ) && ( TREATMENT_BLOOD_PRIME_STATE == getTreatmentState() ) )

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, Updated

Yes, Updated

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Replaced

Replaced

2:11 pm

Sean Nash

This should be invalid state (or something like that).

This should be invalid state (or something like that).

2:11 pm

Sean Nash

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU...

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU32TreatmentParamUpperRangeLimit() functions from the TxParams service.