dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Update alarms and Input/Output sections.

Update alarms and Input/Output sections.

Also, add option individual parameter override for substitutions pump rate as well.

Also, add option individual parameter override for substitutions pump rate as well.

Space after parenthesis. Please add the same in else portion as well (when treatment is in progress, update the rate).

Space after parenthesis. Please add the same in else portion as well (when treatment is in progress, update the rate).

fixed.

fixed.

fixed

fixed

fixed

fixed

fixed

fixed

added

added

All these are more of debug related overrides (acid and bicarb P & I gain). you can keep them in one function, when the implementation is complete, you may remove these. The init function is too bi...

All these are more of debug related overrides (acid and bicarb P & I gain). you can keep them in one function, when the implementation is complete, you may remove these. The init function is too big, group them and split in the functions and call here.

Some of these parameters can be changed over td proxy commands, need not to implement additional overrides.

Some of these parameters can be changed over td proxy commands, need not to implement additional overrides.

I guess all these MACRO implementations should move to function/s to compute the final acid and bicarb volume, that would help to calculate the volumes when Na and Bicarb params changed during trea...

I guess all these MACRO implementations should move to function/s to compute the final acid and bicarb volume, that would help to calculate the volumes when Na and Bicarb params changed during treatment.

looks Bicarb and sodium settings interchanged? There are multiple macros on the same values. remove the duplicates.

looks Bicarb and sodium settings interchanged? There are multiple macros on the same values. remove the duplicates.

33.0?

33.0?

Add comment for each macro.

Add comment for each macro.

For all floats add F at the end, across the file.

For all floats add F at the end, across the file.

Align the comment

Align the comment

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

Substitution pump

Substitution pump

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

Missing comment.

Missing comment.

update comment. next one as well.

update comment. next one as well.

blank line after the banner and maintain alphabetical order of include files.

blank line after the banner and maintain alphabetical order of include files.

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
Done.

Done.

I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.