Activity dd-firmware/

Tree
Accordion

Stats

Commits this week: 56

Total Committers:	16
Last Commit:	11:26
Commits this week:	56

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Today

2 hrs ago

Vendor - TEL - Jashwant Gantyada

More
f7f7527
changed 4 files
LDT-3628-request-to-change-the-target-re, develop

LDT-3628 changed piston pump target rev counts from 2 to 4 bytes

- -6
- +6
/firmware/App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.c
- -2
- +2
/firmware/App/Controllers/ConcentratePumps.h
- History
- Source
- Diff
/firmware/App/.../ConcentratePumps.h
- -16
- +16
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -6
- +6
/firmware/App/Services/FpgaDD.h
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.h

3 hrs ago

Michael Garthwaite

More
LEAHI-DD-FIRMWARE-LDT-3603-1
finished reviewing

4 hrs ago

Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3372-1
resumed reviewing

4 hrs ago

Michael Garthwaite

Friday 13 Mar

2:11 pm

Dara Navaei

More
b753dcd
changed 1 file
LDT-2004-dialysate-composition-dosing-control--dd, LDT-2004-v2-conductivity-sensors and 6 more LEAHI-DD-FIRMWARE-LDT-2004-4

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

2:10 pm

Dara Navaei

More
b2e7c91
changed 8 files
LDT-2004-dialysate-composition-dosing-control--dd, LDT-2004-v2-conductivity-sensors and 6 more LEAHI-DD-FIRMWARE-LDT-2004-4

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -1
- +1
/firmware/App/Controllers/BalancingChamber.h
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.h
- -2
- +2
/firmware/App/Controllers/DialysatePumps.c
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.c
- -2
- +2
/firmware/App/Controllers/DialysatePumps.h
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.h
- -2
- +2
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -2
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -2
- +2
/firmware/App/Modes/ModeGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.h
- -2
- +2
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c

2:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3103-1
finished reviewing

1:45 pm

Vendor - TEL - Jashwant Gantyada

More
76f850f
changed 3 files
LDT-2004-dialysate-composition-dosing-control--dd, LDT-2004-v2-conductivity-sensors and 7 more LEAHI-DD-FIRMWARE-LDT-3103-1

LDT-3103 resolved merge conflicts

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -6
- +27
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -2
- +3
/firmware/App/Modes/ModeGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.h

1:43 pm

Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3103-1
started review

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed

1:31 pm

Vinayakam Mani

11:50 am

Vendor - TEL - Jashwant Gantyada

done changed it.

done changed it.

11:37 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

10:53 am

Vendor - TEL - Jashwant Gantyada

More
9a750b1
changed 1 file
LDT-2004-dialysate-composition-dosing-control--dd, LDT-2004-v2-conductivity-sensors and 7 more LEAHI-DD-FIRMWARE-LDT-3103-1

LDT-3103 updated fill timeout alarm logic and handling

- -12
- +3
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c

9:33 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Remove extra blank line.

Remove extra blank line.

9:31 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

9:28 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

9:24 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)? Controller properties already include a min and max field - can we use those?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

9:16 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Remove blank line.

Remove blank line.

Thursday 12 Mar

10:01 pm

Vendor - TEL - Praneeth Bunne

9:59 pm

Vendor - TEL - Jashwant Gantyada

changed

changed

9:59 pm

Vendor - TEL - Jashwant Gantyada

removed from everywhere

removed from everywhere

9:58 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

9:58 pm

Vendor - TEL - Jashwant Gantyada

More
d056502
changed 1 file
LDT-2004-dialysate-composition-dosing-control--dd, LDT-2004-v2-conductivity-sensors and 7 more LEAHI-DD-FIRMWARE-LDT-3103-1

LDY-3103 addressed code review comments

- -20
- +1
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c

7:25 pm

Dara Navaei

More
c55f70a
changed 1 file
LDT-2004-dialysate-composition-dosing-control--dd, LDT-2004-v2-conductivity-sensors and 7 more LEAHI-DD-FIRMWARE-LDT-3103-1

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

7:25 pm

Dara Navaei

More
c5d66cf
changed 2 files
LDT-2004-dialysate-composition-dosing-control--dd, LDT-2004-v2-conductivity-sensors and 7 more LEAHI-DD-FIRMWARE-LDT-3103-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -2
- +2
/firmware/App/Modes/ModeGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.h

6:14 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Result is a BOOL variable, use FALSE.

Result is a BOOL variable, use FALSE.

5:24 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

5:24 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

5:24 pm

Vendor - TEL - Jashwant Gantyada

done

done

5:24 pm

Vendor - TEL - Jashwant Gantyada

changed accordingly.

changed accordingly.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-16 13:52 -0700