dd-firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above. What does nr stand for?

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

Let's remove this commented line.

Let's remove this commented line.

Add blank line before return.

Add blank line before return.

Add blank line after declarations.

Add blank line after declarations.

Why U32? Why not RECOVER_STATE_T?

Why U32? Why not RECOVER_STATE_T?

Lower case x

Lower case x

Is blood flow in need of a PID controller too?

Is blood flow in need of a PID controller too?

2 blank lines before test support banner

2 blank lines before test support banner

Add blank line before return.

Add blank line before return.

Add blank line before return.

Add blank line before return.

I don't need to edit this file. I will check with Dara to exclude this file from code review.

I don't need to edit this file. I will check with Dara to exclude this file from code review.

LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals. need to split it or need two message id.

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals.
need to split it or need two message id.

Its a problem . Vinay has to decide it

Its a problem . Vinay has to decide it

fixed

fixed

good catch. This needed to be reverted back to normal publishing.

good catch. This needed to be reverted back to normal publishing.

fixed.

fixed.

fixed.

fixed.

no longer needed. removed

no longer needed. removed

updated sampling to be determined on read count rather than fixed timer.

updated sampling to be determined on read count rather than fixed timer.

per formatting for the test support function header. it is format used across many files

per formatting for the test support function header. it is format used across many files