dd-firmware / firmware / App / Services

AlarmMgmtSWFaults.h

Clone Tools

Stats

Commits this week: 3
Total Committers: 11
Last Commit: 28 May
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 28 May
1:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
Wednesday 27 May
4:24 pm

Dara Navaei

3:38 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

2:46 pm

Sean Nash

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop si...

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop similar to UF pump.
GenDialysate mode will have an HDF sub-state that signals this controller from Off to On and would also call separate controller for heater and separate (Switches) monitor for door sensors.

With all of that in mind, I think this unit should have a simpler name like SubPump.

2:39 pm

Sean Nash

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch...

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch state(s) (e.g. while in HDF state, we would expect the cap to be open and stowed and we would want to alarm if that was not the case).

2:36 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:31 pm

Sean Nash

Where is call to HDF controller?

Where is call to HDF controller?

2:31 pm

Sean Nash

Monitors should come before mode mgmt above.

Monitors should come before mode mgmt above.

2:30 pm

Sean Nash

What about HemoDiaFiltration.h?

What about HemoDiaFiltration.h?

2:29 pm

Sean Nash

What about initHDF?

What about initHDF?

2:28 pm

Sean Nash

Where is HemoDiaFiltration.h?

Where is HemoDiaFiltration.h?

2:24 pm

Sean Nash

Why does this file name have pound signs pre/post?

Why does this file name have pound signs pre/post?

2:14 pm

Sean Nash

This macro is already defined in Common.h.

This macro is already defined in Common.h.

2:14 pm

Sean Nash

Align all "=" or none of them.

Align all "=" or none of them.

2:13 pm

Sean Nash

DD HDF control data published should just be state and set rate. TD HDF data would have volume, etc...

DD HDF control data published should just be state and set rate. TD HDF data would have volume, etc...

2:11 pm

Sean Nash

This looks like pump control function. I think TD f/w should be doing this when setting Qsub before sending to DD f/w. Again, I think DD f/w should just be controlling pump to the Qsub rate given b...

This looks like pump control function. I think TD f/w should be doing this when setting Qsub before sending to DD f/w. Again, I think DD f/w should just be controlling pump to the Qsub rate given by TD f/w.
HDF volume should be calculated by TD f/w by integrating commanded Qsub over time.

2:08 pm

Sean Nash

Remove blank line.

Remove blank line.

2:08 pm

Sean Nash

Refactor so that only one return statement at end of function. This is in our coding standards.

Refactor so that only one return statement at end of function. This is in our coding standards.

2:08 pm

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

2:07 pm

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

2:07 pm

Sean Nash

I think TD should be handling all of these rules before setting Qsub and sending to DD.

I think TD should be handling all of these rules before setting Qsub and sending to DD.

2:06 pm

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

2:06 pm

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

2:05 pm

Dara Navaei

Done

Done

2:05 pm

Dara Navaei

Done

Done

1:54 pm

Sean Nash

Generally, DD shouldn't need TMP. TD is calculating TMP. TD is using TMP to calculate Qsub. DD is just getting Qsub from TD and controlling the pump to that rate.

Generally, DD shouldn't need TMP. TD is calculating TMP. TD is using TMP to calculate Qsub. DD is just getting Qsub from TD and controlling the pump to that rate.

1:53 pm

Sean Nash

Indent declarations.

Indent declarations.

1:50 pm

Sean Nash

How can we help you with this?

How can we help you with this?

1:49 pm

Sean Nash

Doesn't match file name. Why do we have a redundant file name with ~ suffix for your new units? If these are backup files from your editor, please do not add these to the git repo (delete them befo...

Doesn't match file name. Why do we have a redundant file name with ~ suffix for your new units? If these are backup files from your editor, please do not add these to the git repo (delete them before commit).

1:48 pm

Sean Nash

DD is not calculating the rate I think. TD is sending target HDF rate to DD. So "calculated" should be "requested" or "commanded".

DD is not calculating the rate I think. TD is sending target HDF rate to DD. So "calculated" should be "requested" or "commanded".