td-firmware / firmware / App / Modes

ModeInitPOST.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 28 May
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 22 Jul
11:32 am

Sean Nash

Swap order of == for these 2 if statements - put constant on left side.

Swap order of == for these 2 if statements - put constant on left side.

11:19 am

Sean Nash

Why?

Why?

11:16 am

Sean Nash

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

11:14 am

Sean Nash

Use ternary operator to explicitly set to TRUE or FALSE.

Use ternary operator to explicitly set to TRUE or FALSE.

9:31 am

Sean Nash

Our TODO comments are all CAPs.

Our TODO comments are all CAPs.

9:25 am

Sean Nash

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

9:21 am

Sean Nash

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

9:19 am

Sean Nash

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

9:18 am

Sean Nash

Should return a BOOL (that is what ModeStandby is expecting).

Should return a BOOL (that is what ModeStandby is expecting).

9:18 am

Sean Nash

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

9:16 am

Sean Nash

Align comment.

Align comment.

9:15 am

Sean Nash

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Tuesday 21 Jul
9:08 am

Sean Nash

Do we need this?

Do we need this?

9:07 am

Sean Nash

Change this to work for any state (passed as parameter).

Change this to work for any state (passed as parameter).

Monday 20 Jul
4:33 pm

Sean Nash

Remove

Remove

4:32 pm

Sean Nash

Alphabetize these includes.

Alphabetize these includes.

4:32 pm

Sean Nash

Why is this commented out?

Why is this commented out?

4:31 pm

Sean Nash

Don't need yet.

Don't need yet.

4:30 pm

Sean Nash

Remove all cleaning related functions.

Remove all cleaning related functions.

4:29 pm

Sean Nash

Don't need this yet.

Don't need this yet.

4:29 pm

Sean Nash

Remove for now.

Remove for now.

4:28 pm

Sean Nash

Missing a comment.

Missing a comment.

4:27 pm

Sean Nash

Remove last 5 messages.

Remove last 5 messages.

4:25 pm

Sean Nash

Remove these. These are Denali modes.

Remove these. These are Denali modes.

4:24 pm

Sean Nash

Remove these for now.

Remove these for now.

1:39 pm

Vendor - TEL - Suresh Dharnala

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before en...

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before entering Pre-Treatment.

Tuesday 14 Jul
5:04 pm

Sean Nash

Is this too early to tell DD to start? Ask Vinay.

Is this too early to tell DD to start? Ask Vinay.

5:01 pm

Sean Nash

Initialize post treatment too.

Initialize post treatment too.

5:01 pm

Sean Nash

Delete this. No treatment params mode in Leahi.

Delete this. No treatment params mode in Leahi.

5:00 pm

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.