dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 22
Total Committers: 13
Last Commit: 17 Apr
Commits this week: 22

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 17 Apr
6:02 pm

Sean Nash

5:17 pm

Vinayakam Mani

Align the comments.

Align the comments.

5:13 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
2:42 pm

Michael Garthwaite

LDT-3984: fixes for defeatured operation

Options
    • -29
    • +35
    ./PermeateTank.c
  2. … 6 more files in changeset.
9:54 am

Vinayakam Mani

Thursday 16 Apr
11:17 pm

Sean Nash and Vinayakam Mani

11:13 pm

Sean Nash

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
5:04 pm

Vendor - TEL - Sameer Poyil

4:23 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
4:19 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./BalancingChamber.c
    • -2
    • +2
    ./ConcentratePumps.h
    • -1
    • +1
    ./DryBiCart.c
    • -1
    • +1
    ./DryBiCart.h
  5. … 5 more files in changeset.
4:13 pm

Vendor - TEL - Sameer Poyil

LDT-2004 merging staging branch to LDT-2004-dialysate-composition-dosing-control--dd

Options
    • -6
    • +6
    ./BalancingChamber.c
    • -1
    • +1
    ./DryBiCart.c
  3. … 4 more files in changeset.
2:55 pm

Vendor - TEL - Sameer Poyil

LDT-2004 addressed review comments

Options
    • -5
    • +0
    ./DryBiCart.c
2:42 pm

Vendor - TEL - Sameer Poyil

LDT-2004 adressed review comments

Options
    • -16
    • +9
    ./DryBiCart.c
2:28 pm

Vendor - TEL - Sameer Poyil

Its static function and not used by external API to pass the wrong id.

Its static function and not used by external API to pass the wrong id.

8:24 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./PermeateTank.c
    • -1
    • +1
    ./ROPump.c
    • -2
    • +2
    ./Valves.c
    • -2
    • +2
    ./Valves.h
  5. … 2 more files in changeset.
8:15 am

Michael Garthwaite

Wednesday 15 Apr
10:08 pm

Vendor - TEL - Sameer Poyil

LDT-2004 Adressed review comments

Options
    • -2
    • +2
    ./ConcentratePumps.h
    • -107
    • +55
    ./DryBiCart.c
9:34 pm

Vendor - TEL - Sameer Poyil

0.0F is made by Sean.

0.0F is made by Sean.

5:31 pm

Sean Nash and Vinayakam Mani

4:12 pm

Michael Garthwaite

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

3:37 pm

Vinayakam Mani

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

9:52 am

Michael Garthwaite

nope. removed.

nope. removed.

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

7:52 am

Michael Garthwaite

LDT-3218: code review comments

Options
    • -0
    • +1
    ./ROPump.c
    • -3
    • +4
    ./Valves.c
    • -1
    • +1
    ./Valves.h
  4. … 1 more file in changeset.
Tuesday 14 Apr
9:22 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./BalancingChamber.c
    • -2
    • +2
    ./Heaters.c
    • -1
    • +1
    ./Heaters.h
    • -2
    • +2
    ./RinsePump.c
    • -1
    • +1
    ./Ultrafiltration.c
  6. … 8 more files in changeset.
7:47 pm

Sean Nash and Vendor - TEL - Sameer Poyil

7:28 pm

Vinayakam Mani

Same comment applies here (removing resetPIController).

Same comment applies here (removing resetPIController).