td-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 38
Total Committers: 15
Last Commit: 13 Aug
Commits this week: 38

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 20 Aug
5:10 pm

Sean Nash

Can we combine this state with prior state? Wait for DD response and mode change in same state?

Can we combine this state with prior state? Wait for DD response and mode change in same state?

5:08 pm

Sean Nash

Only need second condition I think.

Only need second condition I think.

5:02 pm

Sean Nash

This should be switch on requested selection and, in each case, we set next state to wait for disinfect state and set the appropriate command (if not skip) or set next state to wait for treatment (...

This should be switch on requested selection and, in each case, we set next state to wait for disinfect state and set the appropriate command (if not skip) or set next state to wait for treatment (if skip).

4:58 pm

Sean Nash

I think this should be more general start disinfection function that takes a specific disinfection command enum as a parameter.

I think this should be more general start disinfection function that takes a specific disinfection command enum as a parameter.

4:56 pm

Sean Nash

Shouldn't this be UI REQUEST message? Why would we need to receive/handle a message that we send?

Shouldn't this be UI REQUEST message? Why would we need to receive/handle a message that we send?

4:49 pm

Sean Nash

Do we need to send UI a response? Accept/reject?

Do we need to send UI a response? Accept/reject?

4:49 pm

Sean Nash

Is this a message handler? If so, parameter should be a message and option should be extracted from message payload.

Is this a message handler? If so, parameter should be a message and option should be extracted from message payload.

4:48 pm

Sean Nash

Does this command cause DD to transition to standby? It looks like the command to give when we transition into post treatment mode to tell DD to transition to post-gen dialysate mode.

Does this command cause DD to transition to standby? It looks like the command to give when we transition into post treatment mode to tell DD to transition to post-gen dialysate mode.

4:46 pm

Sean Nash

Switch not needed here. Just signal standby mode with the received selection.

Switch not needed here. Just signal standby mode with the received selection.

4:44 pm

Sean Nash

Should be disinfection selection type, not command type. Also, move this down into if statement scope.

Should be disinfection selection type, not command type.
Also, move this down into if statement scope.

4:43 pm

Sean Nash

Why are we signaling a command to standby mode? We should signal the selection that we received from UI. Standby mode (later when we get there) will then look at the selection and decide there whic...

Why are we signaling a command to standby mode? We should signal the selection that we received from UI. Standby mode (later when we get there) will then look at the selection and decide there which command to send to DD.

4:40 pm

Sean Nash

Remove blank line.

Remove blank line.

4:37 pm

Sean Nash

Won't this happen when we transition to auto-eject state? Why do it here?

Won't this happen when we transition to auto-eject state? Why do it here?

4:37 pm

Sean Nash

Shouldn't auto-eject state handle this BP homing?

Shouldn't auto-eject state handle this BP homing?

4:36 pm

Sean Nash

Why are we worried about "handled"? Once confirmed, should we just go to auto eject state?

Why are we worried about "handled"? Once confirmed, should we just go to auto eject state?

4:36 pm

Sean Nash

Why is this if statement separated from the one above? Why not just do this stuff in that if statement?

Why is this if statement separated from the one above? Why not just do this stuff in that if statement?

4:32 pm

Sean Nash

There should be function(s) in DDInterface to tell DD what we want (bypass, Qd, etc...).

There should be function(s) in DDInterface to tell DD what we want (bypass, Qd, etc...).

4:31 pm

Sean Nash

This publish code should be in a publish function and we just call that function here.

This publish code should be in a publish function and we just call that function here.

4:29 pm

Sean Nash

Add comment to right.

Add comment to right.

4:29 pm

Sean Nash

Why is this above the definitions banner?

Why is this above the definitions banner?

4:28 pm

Sean Nash

This signal function looks like a message handler. If so, it should take a message (like handlers below) and get the option from the message payload.

This signal function looks like a message handler. If so, it should take a message (like handlers below) and get the option from the message payload.

4:27 pm

Sean Nash

Needs comment to right.

Needs comment to right.

4:26 pm

Sean Nash

Is TD going to request active cooling or is it going to happen automatically after heat or heat+citric disinfection completes? You have an enum of heat disinfection commands, so why do we need sepa...

Is TD going to request active cooling or is it going to happen automatically after heat or heat+citric disinfection completes?
You have an enum of heat disinfection commands, so why do we need separate messages for each disinfection? Should just be 1 message to start a disinfection with a command enum as its payload.

11:52 am

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

11:51 am

Sean Nash

Fix indenting.

Fix indenting.

11:51 am

Sean Nash

Fix indenting. It's too deep.

Fix indenting. It's too deep.

11:50 am

Sean Nash

Fix indent.

Fix indent.

11:49 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:49 am

Sean Nash

Fix indent.

Fix indent.

11:49 am

Sean Nash

Fix indent.

Fix indent.