td-firmware / firmware / App

TDCommon.h

Clone Tools

Stats

Commits this week: 8
Total Committers: 8
Last Commit: 27 May
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 29 May
2:25 pm

Sean Nash

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

Thursday 28 May
10:43 pm

Sean Nash

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

10:33 pm

Sean Nash

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

Wednesday 27 May
4:24 pm

Dara Navaei

3:41 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
3:40 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./TDCommon.h
  2. … 7 more files in changeset.
3:34 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

2:56 pm

Dara Navaei

Done

Done

1:49 pm

Dara Navaei

LDT_3259 addressed the code review comments

Options
    • -1
    • +1
    ./TDCommon.h
  2. … 1 more file in changeset.
1:47 pm

Dara Navaei

Done

Done

12:39 pm

Dara Navaei

This file was updated automatically using HALCoGen.

This file was updated automatically using HALCoGen.

10:31 am

Dara Navaei

Done

Done

10:26 am

Dara Navaei

Done

Done

10:24 am

Sean Nash

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

10:24 am

Dara Navaei

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

10:22 am

Dara Navaei

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

10:22 am

Dara Navaei

If you disable mpu in the HALCoGen, this code will not be created.

If you disable mpu in the HALCoGen, this code will not be created.

10:16 am

Sean Nash

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

10:14 am

Sean Nash

same.

same.

10:14 am

Sean Nash

same.

same.

10:13 am

Sean Nash

We shouldn't delete Halcogen code. Add a #if 0 in this user code section and add a #endif in the user code section following _coreEnableFlashEcc() call.

We shouldn't delete Halcogen code.
Add a #if 0 in this user code section and add a #endif in the user code section following _coreEnableFlashEcc() call.

9:54 am

Sean Nash

Should this be commented out before merge?

Should this be commented out before merge?

9:53 am

Sean Nash

These are not in alphabetical order. See ModeStandby and ModeService and ModeFault.

These are not in alphabetical order. See ModeStandby and ModeService and ModeFault.

9:47 am

Sean Nash

These should come before PC channels (higher priority).

These should come before PC channels (higher priority).

9:45 am

Dara Navaei

LDT-3259 addressed the code review comments

Options
    • -1
    • +1
    ./TDCommon.h
  2. … 1 more file in changeset.
9:36 am

Dara Navaei

Done

Done

9:36 am

Dara Navaei

Done

Done

9:35 am

Dara Navaei

Done

Done

9:07 am

Sean Nash

Alphabetize.

Alphabetize.

9:04 am

Sean Nash

Comment this out before merge.

Comment this out before merge.