td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Yes,

Yes,

In pre-treatment

In pre-treatment

Fixed

Fixed

Yes, fixed

Yes, fixed

Add a command to turn air pump off here in this state (since we aren't doing that in transition anymore to prevent large pressure drop).

Add a command to turn air pump off here in this state (since we aren't doing that in transition anymore to prevent large pressure drop).

Don't turn off air pump here - looks like we lose too much air pressure when we do that. Move this command to the stabilize state handler (I'll add a comment there).

Don't turn off air pump here - looks like we lose too much air pressure when we do that. Move this command to the stabilize state handler (I'll add a comment there).

You removed it here, but where did it go? I expected to see it in next case below.

You removed it here, but where did it go? I expected to see it in next case below.

Align "="

Align "="

Add comment to right.

Add comment to right.

Better to say != TRUE here.

Better to say != TRUE here.

Add TODO comment as to whether we should trigger an alarm/fault here.

Add TODO comment as to whether we should trigger an alarm/fault here.

Add blank line after declaration. Fix indent.

Add blank line after declaration.
Fix indent.

We can un-comment syringe pump stop now.

We can un-comment syringe pump stop now.

I think this function should be private (called by public message handler).

I think this function should be private (called by public message handler).

Should this be static (private)?

Should this be static (private)?

I don't have a good option. If we're going to change it to pull approach later, can't we just ignore rate changes when doing fluid bolus with sub fluid until you implement the pull approach? Are we...

I don't have a good option. If we're going to change it to pull approach later, can't we just ignore rate changes when doing fluid bolus with sub fluid until you implement the pull approach? Are we even able to do sub fluid bolus yet? Do we have HDF tube sets?

Sure

Sure

I'll implement the pull approach later, this is temporary fix. We need to run Sub pump at Qb rate, if Qb is updated, how can we increase Qsub?

I'll implement the pull approach later, this is temporary fix.
We need to run Sub pump at Qb rate, if Qb is updated, how can we increase Qsub?

Should we check to see if blood sitting timer has not exceeded time limit before we resume (similar to what we do from rinseback stop state before we start an additional)?

Should we check to see if blood sitting timer has not exceeded time limit before we resume (similar to what we do from rinseback stop state before we start an additional)?

So we will command BP every 50ms for saline (okay, but not the pull approach we talked about) and send DD Qsub commands every 50ms for sub fluid (probably not a good idea)?

So we will command BP every 50ms for saline (okay, but not the pull approach we talked about) and send DD Qsub commands every 50ms for sub fluid (probably not a good idea)?

Those transitions to send the pressure result event. That was carried over from the previous implementation. Since the state changes are already reported through the common sub-state/operation-stat...

Those transitions to send the pressure result event. That was carried over from the previous implementation. Since the state changes are already reported through the common sub-state/operation-status events, I'll remove the pressure result event from those individual transitions for consistency.

Need the TDDef.h changes that include the enum naming updates

Need the TDDef.h changes that include the enum naming updates

Should reset happen when transitioning out of this state (into next state)? I think we want to allow time for pressure to stabilize while open to atmosphere after we open these valves before we res...

Should reset happen when transitioning out of this state (into next state)? I think we want to allow time for pressure to stabilize while open to atmosphere after we open these valves before we reset the offsets.

Where are we transitioning to prime?

Where are we transitioning to prime?

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.