td-firmware / firmware / App / Services / StateServices

FluidBolus.c

Clone Tools

Stats

Commits this week: 5
Total Committers: 4
Last Commit: 18:32
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 21 Aug
5:58 pm

Sean Nash

I don't have a good option. If we're going to change it to pull approach later, can't we just ignore rate changes when doing fluid bolus with sub fluid until you implement the pull approach? Are we...

I don't have a good option. If we're going to change it to pull approach later, can't we just ignore rate changes when doing fluid bolus with sub fluid until you implement the pull approach? Are we even able to do sub fluid bolus yet? Do we have HDF tube sets?

5:48 pm

Vendor - TEL - Praneeth Bunne

Sure

Sure

5:44 pm

Vendor - TEL - Praneeth Bunne

I'll implement the pull approach later, this is temporary fix. We need to run Sub pump at Qb rate, if Qb is updated, how can we increase Qsub?

I'll implement the pull approach later, this is temporary fix.
We need to run Sub pump at Qb rate, if Qb is updated, how can we increase Qsub?

5:37 pm

Sean Nash

Should we check to see if blood sitting timer has not exceeded time limit before we resume (similar to what we do from rinseback stop state before we start an additional)?

Should we check to see if blood sitting timer has not exceeded time limit before we resume (similar to what we do from rinseback stop state before we start an additional)?

5:30 pm

Sean Nash

So we will command BP every 50ms for saline (okay, but not the pull approach we talked about) and send DD Qsub commands every 50ms for sub fluid (probably not a good idea)?

So we will command BP every 50ms for saline (okay, but not the pull approach we talked about) and send DD Qsub commands every 50ms for sub fluid (probably not a good idea)?

Thursday 20 Aug
11:52 am

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

11:51 am

Sean Nash

Fix indenting.

Fix indenting.

11:51 am

Sean Nash

Fix indenting. It's too deep.

Fix indenting. It's too deep.

11:50 am

Sean Nash

Fix indent.

Fix indent.

11:49 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:49 am

Sean Nash

Fix indent.

Fix indent.

11:49 am

Sean Nash

Fix indent.

Fix indent.

11:49 am

Sean Nash

Fix indent.

Fix indent.

11:48 am

Sean Nash

Give each alarm its own line.

Give each alarm its own line.

11:46 am

Sean Nash

Add doxygen comment to right.

Add doxygen comment to right.

11:45 am

Sean Nash

Add blank line between includes and group header.

Add blank line between includes and group header.

11:45 am

Sean Nash

Library includes should be first and using <> instead of "". Add comment to right explaining what we're including string.h for.

Library includes should be first and using <> instead of "". Add comment to right explaining what we're including string.h for.

11:44 am

Sean Nash

Alphabetize.

Alphabetize.

11:43 am

Sean Nash

Remove if statements. Just call both set functions regardless of current state.

Remove if statements. Just call both set functions regardless of current state.

11:41 am

Sean Nash

Fix indent. Move up above Dialin "test" message handlers.

Fix indent. Move up above Dialin "test" message handlers.

11:40 am

Sean Nash

Alphabetize.

Alphabetize.

11:40 am

Sean Nash

Follow naming convention that other states have set. This unit should be called StateTxTreatmentEnd.

Follow naming convention that other states have set. This unit should be called StateTxTreatmentEnd.

11:39 am

Sean Nash

Shouldn't this be in your TreatmentEnd unit?

Shouldn't this be in your TreatmentEnd unit?

11:37 am

Sean Nash

Who calls this function? It's public, but no prototype in header file.

Who calls this function? It's public, but no prototype in header file.

11:34 am

Sean Nash

What is this function doing in Dialysis unit? And who is calling it? It's public, but I don't see that you added it to header file so nobody can call it anyway.

What is this function doing in Dialysis unit? And who is calling it? It's public, but I don't see that you added it to header file so nobody can call it anyway.

11:33 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-5624_(TD, SW) UI screen goes to main loading screen when pausing fluid bolus in rinseback
LEAHI-TD-FIRMWARE-LDT-5624_(TD, SW) UI screen goes to main loading screen when pausing fluid bolus in rinseback
11:32 am

Sean Nash

Why add tx end state here?

Why add tx end state here?

11:32 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:30 am

Sean Nash

Keep blank line between functions.

Keep blank line between functions.

11:29 am

Sean Nash

Add blank line before return.

Add blank line before return.