td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 30
Total Committers: 15
Last Commit: 09:33
Commits this week: 30

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

Vinayakam Mani and Michael Garthwaite

8 hrs ago

Raghu Kallala

LDT-4188 updated tx param response as we are not storing confirmation into stagedparams

Options
    • -11
    • +11
    ./Services/TxParams.c
    • -0
    • +29
    ./Services/TxParams.h
10 hrs ago

Raghu Kallala

Updated to ml/min, except for broadcast in treatment mode

Updated to ml/min, except for broadcast in treatment mode

10 hrs ago

Raghu Kallala

LDT-4188 converted UF rate to ml per min in all TD modules which interacts with DD. Broadcast is still in L per hr

Options
    • -3
    • +3
    ./Modes/ModePreTreat.c
    • -2
    • +5
    ./Modes/ModeTreatment.c
    • -12
    • +12
    ./Modes/StateTxDialysis.c
    • -2
    • +2
    ./Services/DDInterface.c
Thursday 30 Apr
3:57 pm

Sean Nash

I don't think you want stored (old) value here. You want value from first message before confirmation.

I don't think you want stored (old) value here. You want value from first message before confirmation.

1:41 pm

Sean Nash

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert ...

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

12:21 pm

Raghu Kallala

Changed to U32

Changed to U32

12:21 pm

Raghu Kallala

we are sending a message ack as response in the handler of this message request

we are sending a message ack as response in the handler of this message request

12:19 pm

Raghu Kallala

LDT-4188 removed type conversion for sub mode

Options
    • -1
    • +1
    ./Modes/ModePreTreat.c
11:56 am

Raghu Kallala

LDT-4188 addressed review comments

Options
    • -1
    • +0
    ./Services/DDInterface.c
    • -1
    • +1
    ./Services/DDInterface.h
    • -1
    • +1
    ./Services/Messaging.c
    • -9
    • +0
    ./TDCommon.h
11:53 am

Raghu Kallala

Other existing set functions in TD is using UF in liter and rate in L/hr Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

11:21 am

Michael Garthwaite and Vinayakam Mani

11:10 am

Sean Nash

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When se...

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

11:01 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:00 am

Sean Nash

Remove extra space before function name.

Remove extra space before function name.

11:00 am

Sean Nash

This is not a Dialin message, so move up above all of these "test" functions.

This is not a Dialin message, so move up above all of these "test" functions.

10:59 am

Sean Nash

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate dox...

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

10:29 am

Raghu Kallala

LDT-4188 rearranged variable declarations

Options
    • -3
    • +3
    ./Modes/ModePreTreat.c
10:23 am

Raghu Kallala

LDT-4188 added get api for dialysate data

Options
    • -1
    • +1
    ./Modes/ModePreTreat.c
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
    • -1
    • +49
    ./Services/DDInterface.c
    • -0
    • +2
    ./Services/DDInterface.h
    • -0
    • +1
    ./Services/Messaging.c
    • -0
    • +9
    ./TDCommon.h
9:55 am

Vinayakam Mani

Do we have a return confirmation that the command is accepted by DD?

Do we have a return confirmation that the command is accepted by DD?

9:45 am

Vinayakam Mani

Is the UF rate unit in ml/min (instead of hr.)?

Is the UF rate unit in ml/min (instead of hr.)?

9:36 am

Vinayakam Mani

Are we assuming the sub mode return is pre-gen sub mode always?

Are we assuming the sub mode return is pre-gen sub mode always?

8:41 am

Michael Garthwaite

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

8:37 am

Michael Garthwaite

comment still needed?

comment still needed?

7:10 am

Raghu Kallala

LDT-4188 fixed typo and spacing

Options
    • -2
    • +2
    ./Modes/ModePreTreat.c
    • -1
    • +1
    ./Modes/ModeStandby.c
7:06 am

Raghu Kallala

LDT-4188 updated include headers

Options
    • -0
    • +1
    ./Modes/ModePreTreat.h
Wednesday 29 Apr
3:54 pm

Raghu Kallala

LDT-4188 added dialysate pre-gen call before transition to pre-tx

Options
    • -4
    • +27
    ./Modes/ModePreTreat.c
    • -0
    • +8
    ./Modes/ModeStandby.c
    • -0
    • +41
    ./Services/DDInterface.c
    • -0
    • +1
    ./Services/DDInterface.h
2:01 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
11:02 am

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
11:02 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Modes/ModeStandby.c
    • -2
    • +2
    ./Modes/ModeTreatment.c
    • -2
    • +2
    ./Modes/ModeTreatment.h
    • -2
    • +2
    ./Modes/StateTxDialysis.c
    • -2
    • +2
    ./Monitors/Pressures.c
    • -2
    • +2
    ./Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./Services/DDInterface.c
    • -2
    • +2
    ./Services/DDInterface.h
    • -2
    • +2
    ./Services/Messaging.c
    • -2
    • +2
    ./Services/TxParams.c
    • -2
    • +2
    ./Services/TxParams.h
    • -2
    • +2
    ./TDCommon.h