td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 28
Total Committers: 17
Last Commit: 05 Jun
Commits this week: 28

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 05 Jun
4:14 pm

Sean Nash

Just use 0x0 and 0xFFFFFFFF

Just use 0x0 and 0xFFFFFFFF

4:13 pm

Sean Nash

NUM_OF_BATTERY_REGISTERS - 1

NUM_OF_BATTERY_REGISTERS - 1

4:13 pm

Sean Nash

Put 2 items at end of the list here: BATTERY_END_OF_LIST_TIME_TO_PUBLISH NUM_OF_BATTERY_REGISTERS

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

4:10 pm

Sean Nash

Put this one back to NUM_OF_BATTERY_DEVICES.

Put this one back to NUM_OF_BATTERY_DEVICES.

4:08 pm

Sean Nash

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

4:04 pm

Sean Nash

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

1:36 pm

Sean Nash

1:23 pm

Vendor - TEL - Arpita Srivastava

Please add Alarm ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Please add Alarm
ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

1:19 pm

Vendor - TEL - Arpita Srivastava

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

1:16 pm

Vendor - TEL - Arpita Srivastava

Please add currentPreTreatmentState to inputs.

Please add currentPreTreatmentState to inputs.

1:07 pm

Vendor - TEL - Arpita Srivastava

currentPreTxRecircState looks like an input.

currentPreTxRecircState looks like an input.

10:30 am

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
10:29 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/BloodFlow.c
    • -2
    • +2
    ./Modes/ModePreTreat.c
    • -2
    • +2
    ./Modes/ModeTreatment.c
    • -2
    • +2
    ./Modes/ModeTreatment.h
    • -2
    • +2
    ./Modes/StateTxBloodPrime.c
    • -2
    • +2
    ./Modes/StateTxBloodPrime.h
    • -2
    • +2
    ./Modes/StateTxDialysis.c
    • -2
    • +2
    ./Modes/StateTxDialysis.h
    • -2
    • +2
    ./Modes/StateTxPaused.c
    • -2
    • +2
    ./Modes/StateTxPaused.h
    • -2
    • +2
    ./Monitors/Pressures.h
    • -2
    • +2
    ./Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./Services/AlarmMgmtTD.h
    • -2
    • +2
    ./Services/DDInterface.c
    • -2
    • +2
    ./Services/DDInterface.h
  16. … 7 more files in changeset.
10:08 am

Sean Nash

9:46 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4505_(TD) H4 blood pump does not run in reverse
LEAHI-TD-FIRMWARE-LDT-4505_(TD) H4 blood pump does not run in reverse
Thursday 04 Jun
1:44 pm

Sean Nash

Put recirc state after Rx state (both here in switch statement and also in enumeration).

Put recirc state after Rx state (both here in switch statement and also in enumeration).

1:43 pm

Sean Nash

Put in alphabetical order (before Timers.h).

Put in alphabetical order (before Timers.h).

1:41 pm

Sean Nash

Where do we trigger high priority prime completed alarm?

Where do we trigger high priority prime completed alarm?

1:39 pm

Sean Nash

Dialysate rate should be set to the Qd user setting (from Tx params).

Dialysate rate should be set to the Qd user setting (from Tx params).

1:32 pm

Sean Nash

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.

9:52 am

Vendor - TEL - Jashwant Gantyada

9:35 am

Vendor - TEL - Praneeth Bunne

LDT-4013: Merge latest staging into LDT-4013, resolved merge conflicts and addressed CR comments

Options
    • -18
    • +203
    ./Modes/ModePreTreat.c
    • -12
    • +23
    ./Modes/ModeTreatment.c
    • -18
    • +19
    ./Modes/ModeTreatment.h
    • -2
    • +2
    ./Monitors/Pressures.h
    • -5
    • +12
    ./Services/AlarmMgmtSWFaults.h
    • -3
    • +71
    ./Services/Messaging.c
    • -61
    • +23
    ./Services/Messaging.h
    • -0
    • +635
    ./Services/StateServices/FluidBolus.c
    • -0
    • +75
    ./Services/StateServices/FluidBolus.h
    • -0
    • +437
    ./Services/StateServices/TubeSetAutoEject.c
    • -0
    • +335
    ./Services/StateServices/TubeSetInstall.c
    • -628
    • +0
    ./Services/FluidBolus.c
    • -75
    • +0
    ./Services/FluidBolus.h
9:00 am

Sean Nash

Should this check be moved to the fluid bolus exec function?

Should this check be moved to the fluid bolus exec function?

Wednesday 03 Jun
2:01 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4027_Pre-Treatment - FW Implementation - 2/6:
LEAHI-TD-FIRMWARE-LDT-4027_Pre-Treatment - FW Implementation - 2/6:
12:29 pm

Vinayakam Mani

12:28 pm

Vendor - TEL - Praneeth Bunne

LDT-4013: Refactored and updated logic.

Options
    • -0
    • +5
    ./Modes/ModePreTreat.c
    • -3
    • +4
    ./Modes/ModeTreatment.c
    • -1
    • +1
    ./Modes/ModeTreatment.h
    • -20
    • +63
    ./Modes/StateTxBloodPrime.c
    • -1
    • +1
    ./Modes/StateTxDialysis.c
    • -7
    • +16
    ./Services/FluidBolus.c
    • -2
    • +2
    ./Services/FluidBolus.h
9:51 am

Sean Nash

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD...

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

9:48 am

Sean Nash

Add doxygen comments to the right of each structure field.

Add doxygen comments to the right of each structure field.

9:47 am

Sean Nash

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

9:46 am

Sean Nash

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).