firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
This dead band control ? here is the ideal place , may be BC to incldue the .h from drybicart

This dead band control ? here is the ideal place , may be BC to incldue the .h from drybicart

LEAHI-DD-FIRMWARE-LDT-4413_Synchronize the Change events content
LEAHI-DD-FIRMWARE-LDT-4413_Synchronize the Change events content
LDT-4413 fixed the order how data1 and data2 parsed in FP event calls

    • -0
    • +2
    ./App/Modes/FPModes/FPOperationModes.c
    • -1
    • +1
    ./App/Modes/FPModes/ModePreGenPermeate.c
    • -1
    • +1
    ./App/Modes/FPModes/ModePreGenPermeateDefeatured.c
Why did we remove this? This is needed for BC Switch only condition.

Why did we remove this? This is needed for BC Switch only condition.

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

LDT-4188 merge latest from staging

Is this defined elsewhere? We shouldn't define this in multiple places. I think it should be in one header file - maybe balancing chamber controller.

Is this defined elsewhere? We shouldn't define this in multiple places. I think it should be in one header file - maybe balancing chamber controller.

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Use the get Acid mix control interval?

Use the get Acid mix control interval?

Updates the comments for all new variables.

Updates the comments for all new variables.

Remove this flag.

Remove this flag.

Remove this code.

Remove this code.

There should be a \b before the type of details (Inputs and Outputs here) for documentation please update for all

There should be a \b before the type of details (Inputs and Outputs here) for documentation please update for all

Remove blank line

Remove blank line