dd-firmware / firmware / App / Controllers

ConcentratePumps.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 6
Last Commit: 14 Jul
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Jul
9:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
Tuesday 14 Jul
2:43 pm

Sean Nash

Remove blank line.

Remove blank line.

2:42 pm

Sean Nash

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

2:37 pm

Sean Nash

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

2:32 pm

Sean Nash

Add blank line between declarations and rest of function code (throughout this unit)

Add blank line between declarations and rest of function code (throughout this unit)

2:31 pm

Sean Nash

Add blank line before return statement. ( throughout this unit )

Add blank line before return statement. ( throughout this unit )

2:31 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:29 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:29 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:29 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:29 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:28 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:28 pm

Sean Nash

Indent too deep here.

Indent too deep here.

2:27 pm

Sean Nash

Remove blank line.

Remove blank line.

2:26 pm

Sean Nash

Indent looks too deep here.

Indent looks too deep here.

2:25 pm

Sean Nash

1 blank line here is sufficient.

1 blank line here is sufficient.

1:30 pm

Sean Nash

Remove blank line.

Remove blank line.

1:29 pm

Sean Nash

Remove blank line.

Remove blank line.

1:29 pm

Sean Nash

Remove blank line.

Remove blank line.

1:28 pm

Sean Nash

Add a blank line after private defs banner.

Add a blank line after private defs banner.

1:24 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:24 pm

Sean Nash

Remove blank line.

Remove blank line.

1:22 pm

Sean Nash

Just 1 blank line here is sufficient.

Just 1 blank line here is sufficient.

1:14 pm

Sean Nash

Since these are coming from UI s/w now (right?), I don't think they should begin with "test" which we reserve for messages that only come from Dialin. Move up above "test" functions.

Since these are coming from UI s/w now (right?), I don't think they should begin with "test" which we reserve for messages that only come from Dialin.
Move up above "test" functions.

1:03 pm

Sean Nash

This is a common unit - could be built into DD or TD f/w. Need #ifdef to see if _DD_ or _TD_ build so you know which messaging and records to initialize.

This is a common unit - could be built into DD or TD f/w. Need #ifdef to see if _DD_ or _TD_ build so you know which messaging and records to initialize.

1:00 pm

Sean Nash

These don't look like UI alarms. Comment suggests we already know what to call these. Why aren't we just using the names we want?

These don't look like UI alarms. Comment suggests we already know what to call these. Why aren't we just using the names we want?