td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 24
Total Committers: 18
Last Commit: 28 Jan
Commits this week: 24

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 10 Jul
3:33 pm

Vendor - TEL - Praneeth Bunne

it will be adjusted when I merge latest staging

it will be adjusted when I merge latest staging

3:31 pm

Vendor - TEL - Praneeth Bunne

not required anymore, forgot to remove

not required anymore, forgot to remove

3:21 pm

Sean Nash

I think a comment here is needed. Keep it and maybe mention rinseback alarm responses too.

I think a comment here is needed. Keep it and maybe mention rinseback alarm responses too.

3:20 pm

Sean Nash

Maybe this should be handled in OperationModes exec since it applies to all confirmations (not just alarm related ones).

Maybe this should be handled in OperationModes exec since it applies to all confirmations (not just alarm related ones).

3:19 pm

Sean Nash

There will be confirmations that are not handled here (e.g. power off). So we shouldn't fault in default - we should do nothing.

There will be confirmations that are not handled here (e.g. power off). So we shouldn't fault in default - we should do nothing.

3:17 pm

Sean Nash

Shutdown would be handled somewhere else (buttons.c probably). It's not related to alarms.

Shutdown would be handled somewhere else (buttons.c probably). It's not related to alarms.

3:09 pm

Sean Nash

Is this still possible since we're not returning to TxPaused from rinseback anymore?

Is this still possible since we're not returning to TxPaused from rinseback anymore?

11:17 am

Sean Nash

Is rinseback completed an indication that we've done a blood prime following a temporary break? If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjus...

Is rinseback completed an indication that we've done a blood prime following a temporary break?
If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjust the UF rate so that we will reach the new (larger) UF volume when the treatment completes.
We also need to add RB volume to UF volume in pre-tx when treatment parameters are given/validated (for the final rinseback which we will always have so we should just plan for it before treatment starts).

11:03 am

Sean Nash

What if multiple confirmations pending? Which ID will this function return?

What if multiple confirmations pending? Which ID will this function return?

10:54 am

Sean Nash

Align comments. Should substitution pump data be moved down to 0xBA instead of commented out?

Align comments.
Should substitution pump data be moved down to 0xBA instead of commented out?

Thursday 09 Jul
4:22 pm

Vendor - TEL - Praneeth Bunne and Sean Nash

2:07 pm

Sean Nash

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

1:36 pm

Sean Nash

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

1:33 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
1:32 pm

Sean Nash

I believe the SyringePump controller will trigger this alarm at end of seek operation.

I believe the SyringePump controller will trigger this alarm at end of seek operation.

1:28 pm

Sean Nash

Syringe pump should already be stopped if preload is done. Do we need to call this here?

Syringe pump should already be stopped if preload is done. Do we need to call this here?

1:24 pm

Sean Nash

This is called from preload state. Not needed here I think.

This is called from preload state. Not needed here I think.

1:22 pm

Sean Nash

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

1:20 pm

Sean Nash

Why (void)?

Why (void)?

1:16 pm

Sean Nash

Where is this being called? Should be called from pre-treatment init I think.

Where is this being called? Should be called from pre-treatment init I think.

1:13 pm

Sean Nash

Confirmation signal sounds like a message handler from UI. Message handlers must accept a message as parameter and return BOOL. They must also be added to the message handler table in Messaging.c.

Confirmation signal sounds like a message handler from UI. Message handlers must accept a message as parameter and return BOOL. They must also be added to the message handler table in Messaging.c.

1:11 pm

Sean Nash

Why are we signaling syringe load confirmed here?

Why are we signaling syringe load confirmed here?

1:11 pm

Sean Nash

Do these states need to be public?

Do these states need to be public?

1:08 pm

Sean Nash

Move up one row to alphabetize.

Move up one row to alphabetize.

9:00 am

Sean Nash

If this reserved2 is a U32, next register would be at 288 (not 285). Should we make reserved2 a U08?

If this reserved2 is a U32, next register would be at 288 (not 285). Should we make reserved2 a U08?

Tuesday 07 Jul
3:16 pm

Sean Nash

3:16 pm

Sean Nash

11:42 am

Vendor - TEL - Praneeth Bunne

change accordingly

change accordingly

11:42 am

Vendor - TEL - Praneeth Bunne

Rename to AlarmTableResposnePayload

Rename to AlarmTableResposnePayload

Monday 06 Jul
1:56 pm

Sean Nash