td-firmware / firmware / App / Modes

StateTxDialysis.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 9
Last Commit: 20 Aug
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 20 Aug
11:52 am

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

11:51 am

Sean Nash

Fix indenting.

Fix indenting.

11:51 am

Sean Nash

Fix indenting. It's too deep.

Fix indenting. It's too deep.

11:50 am

Sean Nash

Fix indent.

Fix indent.

11:49 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:49 am

Sean Nash

Fix indent.

Fix indent.

11:49 am

Sean Nash

Fix indent.

Fix indent.

11:49 am

Sean Nash

Fix indent.

Fix indent.

11:48 am

Sean Nash

Give each alarm its own line.

Give each alarm its own line.

11:46 am

Sean Nash

Add doxygen comment to right.

Add doxygen comment to right.

11:45 am

Sean Nash

Add blank line between includes and group header.

Add blank line between includes and group header.

11:45 am

Sean Nash

Library includes should be first and using <> instead of "". Add comment to right explaining what we're including string.h for.

Library includes should be first and using <> instead of "". Add comment to right explaining what we're including string.h for.

11:44 am

Sean Nash

Alphabetize.

Alphabetize.

11:43 am

Sean Nash

Remove if statements. Just call both set functions regardless of current state.

Remove if statements. Just call both set functions regardless of current state.

11:41 am

Sean Nash

Fix indent. Move up above Dialin "test" message handlers.

Fix indent. Move up above Dialin "test" message handlers.

11:40 am

Sean Nash

Alphabetize.

Alphabetize.

11:40 am

Sean Nash

Follow naming convention that other states have set. This unit should be called StateTxTreatmentEnd.

Follow naming convention that other states have set. This unit should be called StateTxTreatmentEnd.

11:39 am

Sean Nash

Shouldn't this be in your TreatmentEnd unit?

Shouldn't this be in your TreatmentEnd unit?

11:37 am

Sean Nash

Who calls this function? It's public, but no prototype in header file.

Who calls this function? It's public, but no prototype in header file.

11:34 am

Sean Nash

What is this function doing in Dialysis unit? And who is calling it? It's public, but I don't see that you added it to header file so nobody can call it anyway.

What is this function doing in Dialysis unit? And who is calling it? It's public, but I don't see that you added it to header file so nobody can call it anyway.

11:32 am

Sean Nash

Why add tx end state here?

Why add tx end state here?

11:32 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:30 am

Sean Nash

Keep blank line between functions.

Keep blank line between functions.

11:29 am

Sean Nash

Add blank line before return.

Add blank line before return.

11:29 am

Sean Nash

Remove blank lines.

Remove blank lines.

11:27 am

Sean Nash

Alphabetize.

Alphabetize.

11:27 am

Sean Nash

Why include twice?

Why include twice?

11:27 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:26 am

Sean Nash

Fix indents

Fix indents

11:26 am

Sean Nash

Fix indents and align with others.

Fix indents and align with others.