dd-firmware

Clone Tools

Stats

Commits this week: 40
Total Committers: 14
Last Commit: 10:28
Commits this week: 40

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
9 hrs ago

Sean Nash

Is this temporary? If so, put a TODO to remove later.

Is this temporary? If so, put a TODO to remove later.

9 hrs ago

Sean Nash

Remove extra spaces between { and msg name.

Remove extra spaces between { and msg name.

9 hrs ago

Sean Nash

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC e...

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

9 hrs ago

Sean Nash

Do these belong in the spent chamber fill group?

Do these belong in the spent chamber fill group?

12 hrs ago

Sean Nash

Add space before ).

Add space before ).

12 hrs ago

Sean Nash

Add space between if and (.

Add space between if and (.

12 hrs ago

Sean Nash

Be consistent on whether you have a blank line between break and next case.

Be consistent on whether you have a blank line between break and next case.

12 hrs ago

Sean Nash

Keep blank line here.

Keep blank line here.

12 hrs ago

Sean Nash

What are these coefficients for? At least describe in comments, if not the names.

What are these coefficients for? At least describe in comments, if not the names.

12 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

12 hrs ago

Sean Nash

12 hrs ago

Sean Nash

13 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Added.

Added.

13 hrs ago

Varshini Nagabooshanam <ven.vnagabooshanam@diality.com>

LDT-618-dd-add-ability-to-override-fixes

Options
    • -2
    • +7
    /firmware/App/Services/TDInterface.c
13 hrs ago

Vendor - TEL - Jashwant Gantyada

I think you are seeing previous commit. It is not there in the present code.

I think you are seeing previous commit. It is not there in the present code.

13 hrs ago

Vendor - TEL - Jashwant Gantyada

Done. Thank you.

Done. Thank you.

13 hrs ago

Vendor - TEL - Jashwant Gantyada

Changed. Thank you.

Changed. Thank you.

14 hrs ago

Dara Navaei

We still need this if statement.

We still need this if statement.

15 hrs ago

Raghu Kallala

Add a 1 second persistence on this alarm

Add a 1 second persistence on this alarm

16 hrs ago

Raghu Kallala

Handle transition here after changing the flush logic transitionToGenPermeateDefeaturedMode(); requestGenWaterDefStart();

Handle transition here after changing the flush logic

transitionToGenPermeateDefeaturedMode();
requestGenWaterDefStart();

16 hrs ago

Raghu Kallala

Need to remove this handler

Need to remove this handler

16 hrs ago

Raghu Kallala

Add blank line before return statement

Add blank line before return statement

16 hrs ago

Raghu Kallala

Remove handlePreGenPDefInletWaterState

Remove handlePreGenPDefInletWaterState

16 hrs ago

Raghu Kallala

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

16 hrs ago

Raghu Kallala

Call this in both Pre Gen: Verify Water and Gen Permeate

Call this in both Pre Gen: Verify Water and Gen Permeate

16 hrs ago

Raghu Kallala

Greater than or equal to for low limit pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG Also give space before and after parentheses.

Greater than or equal to for low limit
pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG

Also give space before and after parentheses.

16 hrs ago

Raghu Kallala

Put quadratic and linear terms in parentheses.

Put quadratic and linear terms in parentheses.

16 hrs ago

Vendor - TEL - Varshini Nagabooshanam and Sean Nash

Wednesday 10 Dec
8:03 pm

Vendor - TEL - Sameer Poyil

is it merge issue ?

is it merge issue ?

7:56 pm

Vendor - TEL - Sameer Poyil

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here