Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I don't need to edit this file. I will check with Dara to exclude this file from code review.

I don't need to edit this file. I will check with Dara to exclude this file from code review.

LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals. need to split it or need two message id.

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals.
need to split it or need two message id.

Its a problem . Vinay has to decide it

Its a problem . Vinay has to decide it

fixed

fixed

good catch. This needed to be reverted back to normal publishing.

good catch. This needed to be reverted back to normal publishing.

fixed.

fixed.

fixed.

fixed.

no longer needed. removed

no longer needed. removed

updated sampling to be determined on read count rather than fixed timer.

updated sampling to be determined on read count rather than fixed timer.

per formatting for the test support function header. it is format used across many files

per formatting for the test support function header. it is format used across many files

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Done.

Done.