bootloader

firmware

Clone Tools

Stats

Commits this week: 1
Total Committers: 1
Last Commit: 21 Jan
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 08 Mar
2:22 pm

Dara Navaei

Friday 27 Feb
9:14 am

Sean Nash

else shouldn't we go back to waiting for an update or something? Seems wrong to just get stuck here.

else shouldn't we go back to waiting for an update or something? Seems wrong to just get stuck here.

9:12 am

Sean Nash

Is Noe never going to change these IDs? I think he has already changed DD fpga ID for beta 2.0. If these IDs are not fixed forever, we cannot hardcode them here in the bootloader code.

Is Noe never going to change these IDs? I think he has already changed DD fpga ID for beta 2.0. If these IDs are not fixed forever, we cannot hardcode them here in the bootloader code.

9:08 am

Sean Nash

We can't jump to app if fpga ID is bad? Why not?

We can't jump to app if fpga ID is bad? Why not?

9:03 am

Sean Nash

Where is this function defined?

Where is this function defined?

8:59 am

Sean Nash

Align comments

Align comments

8:57 am

Sean Nash

Why 2 conditions? Are there 2 ways to initiate an update? And why isn't this check done in the CHECK_FOR_UPDATE_STATE?

Why 2 conditions? Are there 2 ways to initiate an update?

And why isn't this check done in the CHECK_FOR_UPDATE_STATE?

Wednesday 21 Jan
5:17 pm

Dara Navaei

LEAHI-BOOTLOADER-LDT-3259_Software Update - TD
LEAHI-BOOTLOADER-LDT-3259_Software Update - TD
11:20 am

Dara Navaei

LEAH-1415 updated the bootloader code to be more comaptible with Leahi

Options
    • -1
    • +1
    ./App/Modes/ModeStandby.c
    • -7
    • +9
    ./App/Modes/OperationModes.c
    • -11
    • +10
    ./App/Services/FPGA.c
    • -2
    • +2
    ./source/sys_startup.c
Tuesday 20 Jan
2:40 pm

Sean Nash

TODO

TODO

2:39 pm

Sean Nash

TODO

TODO

2:39 pm

Sean Nash

TODO should be all caps.

TODO should be all caps.

2:39 pm

Sean Nash

TODO should be all caps for consistency (so we know what to search for).

TODO should be all caps for consistency (so we know what to search for).

2:38 pm

Sean Nash

I think it should be restored even if it's not used anywhere yet.

I think it should be restored even if it's not used anywhere yet.

2:34 pm

Sean Nash

Do we need an end of group marker down here?

Do we need an end of group marker down here?

2:34 pm

Sean Nash

Can you capture intent to resolve my comment in a TODO so we don't lose track of it? (General recommendation for all comments that we are postponing resolution for).

Can you capture intent to resolve my comment in a TODO so we don't lose track of it? (General recommendation for all comments that we are postponing resolution for).

2:31 pm

Sean Nash

Can we put test code inside of #ifdef TEST_CODE_ENABLED or something so that it is easy to remove later?

Can we put test code inside of #ifdef TEST_CODE_ENABLED or something so that it is easy to remove later?

Saturday 17 Jan
4:39 pm

Dara Navaei

LEAH-1415 addressed the code review comments

Options
    • -18
    • +10
    ./App/Modes/ModeStandby.c
    • -5
    • +7
    ./App/Modes/ModeUpdate.c
    • -4
    • +6
    ./App/Modes/OperationModes.c
    • -0
    • +2
    ./App/Services/Comm.c
    • -10
    • +7
    ./App/Services/CommBuffers.c
    • -8
    • +3
    ./App/Services/Download.c
    • -2
    • +3
    ./App/Services/FPGA.c
    • -0
    • +2
    ./App/Tasks/TaskBG.c
    • -0
    • +2
    ./App/Tasks/TaskGeneral.c
    • -0
    • +2
    ./App/Tasks/TaskPriority.c
    • -0
    • +2
    ./App/Tasks/TaskPriority.h
    • -0
    • +5
    ./source/sys_main.c
4:30 pm

Dara Navaei

It will be implemented in the new branch.

It will be implemented in the new branch.

4:30 pm

Dara Navaei

Done

Done

4:08 pm

Dara Navaei

Done

Done

3:59 pm

Dara Navaei

Done

Done

3:59 pm

Dara Navaei

Done

Done

3:58 pm

Dara Navaei

Removed the variable.

Removed the variable.

3:55 pm

Dara Navaei

Removed the TODO.

Removed the TODO.

3:55 pm

Dara Navaei

Removed the interrupt.

Removed the interrupt.

3:55 pm

Dara Navaei

Done

Done

3:36 pm

Dara Navaei

The new update request is checked on top of the mode update exec function. If there is a new update, it will request a transition otherwise, this is a terminal state.

The new update request is checked on top of the mode update exec function. If there is a new update, it will request a transition otherwise, this is a terminal state.

3:32 pm

Dara Navaei

It is the update mode re-initialized. The initialization is done using other functions that have their own doxygen comments. Do I need to add more here?

It is the update mode re-initialized. The initialization is done using other functions that have their own doxygen comments. Do I need to add more here?

3:30 pm

Dara Navaei

Added the return of a value.

Added the return of a value.