dd-firmware / firmware

source

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 31 Dec 69
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Jul
11:22 am

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

11:06 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

11:05 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

10:39 am

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?

10:31 am

Dara Navaei

Any fault alarm here?

Any fault alarm here?

10:18 am

Dara Navaei

Have these variables been initialized correctly?

Have these variables been initialized correctly?

Wednesday 22 Jul
1:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1:08 pm

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

1:07 pm

Sean Nash

Why commented out?

Why commented out?

Wednesday 15 Jul
3:03 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-DD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
9:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
Tuesday 14 Jul
2:43 pm

Sean Nash

Remove blank line.

Remove blank line.

2:42 pm

Sean Nash

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

2:37 pm

Sean Nash

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

2:32 pm

Sean Nash

Add blank line between declarations and rest of function code (throughout this unit)

Add blank line between declarations and rest of function code (throughout this unit)

2:31 pm

Sean Nash

Add blank line before return statement. ( throughout this unit )

Add blank line before return statement. ( throughout this unit )

2:31 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:29 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:29 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:29 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:29 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:28 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:28 pm

Sean Nash

Indent too deep here.

Indent too deep here.

2:27 pm

Sean Nash

Remove blank line.

Remove blank line.

2:26 pm

Sean Nash

Indent looks too deep here.

Indent looks too deep here.