Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
updated

updated

APPROVED.

APPROVED.

RESOLVED. Added another comment regarding the same.

RESOLVED.
Added another comment regarding the same.

Nicholas Ramirez Thanks for the change to the ok and result. *To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the fun...

Nicholas Ramirez
Thanks for the change to the ok and result.

  • To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
  • Also move the:
    ; if ( ! ok ) { goto invalid; }
    

    on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

APPROVED

APPROVED

updated

updated

updated

updated

updated

updated

remove the ok and just check result and if any fails goto invalid

remove the ok and just check result and if any fails goto invalid

see if you can use payloadLen from MessageGlobals.h

see if you can use payloadLen from MessageGlobals.h

double check

double check

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

remove from prime // priming - TODO check if needed. may not need

remove from prime // priming - TODO check if needed. may not need

LEAHI-APPLICATION-LDT-5445_End of Treatment - SW - 01- Notification - R&I
LEAHI-APPLICATION-LDT-5445_End of Treatment - SW - 01- Notification - R&I
LEAHI-APPLICATION-LDT-5414_Disposable Tube Set Auto Priming Process - SW - 01- Pre-Tx - Prime - R&I
LEAHI-APPLICATION-LDT-5414_Disposable Tube Set Auto Priming Process - SW - 01- Pre-Tx - Prime - R&I
LEAHI-APPLICATION-LDT-5158_SW Misc & Enhc - SW - 01 - SW Integration - Calibration - R&I
LEAHI-APPLICATION-LDT-5158_SW Misc & Enhc - SW - 01 - SW Integration - Calibration - R&I
LEAHI-APPLICATION-LDT-5246_System Interface for Users - SW - 01 - Bicarb/Acid Low Replacement - R&I
LEAHI-APPLICATION-LDT-5246_System Interface for Users - SW - 01 - Bicarb/Acid Low Replacement - R&I
LDT-1788 - Feature/LDT-1788 - General Alarm Instructions With New Design
LDT-1788 - Feature/LDT-1788 - General Alarm Instructions With New Design