leahi-application

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
updated

updated

updated

updated

updated

updated

updated

updated

LDT-5602 Service - SW - Calibration Records DD - I&C - 02: SDD - Design Diagram - plantuml & Review

addre4ss cr comments

send rejection reasons

send rejection reasons

add separate sections for each set of messages

add separate sections for each set of messages

add alt rejection for this

add alt rejection for this

move these under the alt password check

move these under the alt password check

bn approves

bn approves

BN approvo

BN approvo

LDT-5602 Service - SW - Calibration Records DD - I&C - 02: SDD - Design Diagram - plantuml & Review

add sdd

    • -0
    • +166
    /SDDs/DD_Calibration.puml
    • binary
    /SDDs/dd_calibration.png
LEAHI-APPLICATION-LDT-5600_Service - SW - Calibration Records DD - I&C
LEAHI-APPLICATION-LDT-5600_Service - SW - Calibration Records DD - I&C
Merge branch 'LDT-5618-sw-misc-enhc-sw-board-freeze' into staging

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
Updated the Alarm Mapping with the staging.

    • -16
    • +16
    /etc/reports/alarms/AlarmMapping.csv
    • -16
    • +16
    /etc/reports/alarms/AlarmMapping.py
    • -16
    • +16
    /sources/model/hd/alarm/MAlarmMapping.cpp
Merge branch 'LDT-5618-sw-misc-enhc-sw-board-freeze' into staging

Adding Alarm Mapping, since the automation is now disabled for migrations.

    • -1
    • +111
    /etc/reports/alarms/AlarmMapping.csv
    • -5
    • +128
    /etc/reports/alarms/AlarmMapping.py
    • -250
    • +457
    /etc/reports/cppcheck/cppcheck.err
    • -652
    • +1275
    /etc/reports/cppcheck/cppcheck.log
    • -24
    • +24
    /sources/model/hd/alarm/MAlarmMapping.cpp
Remove AlarmDialog Animation & Diagnostics open

    • -1
    • +1
    /sources/gui/qml/components/HeaderBar.qml
    • -2
    • +2
    /sources/gui/qml/components/ModalDialog.qml
    • -1
    • +1
    /sources/gui/qml/dialogs/AlarmDialog.qml
Removing the layers and dropshadow and the diagnostics screen

    • -13
    • +13
    /sources/gui/qml/components/ModalDialog.qml
    • -11
    • +11
    /sources/gui/qml/dialogs/AlarmDialog.qml
LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I
LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I
updated

updated

APPROVED.

APPROVED.

RESOLVED. Added another comment regarding the same.

RESOLVED.
Added another comment regarding the same.

Nicholas Ramirez Thanks for the change to the ok and result. *To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the fun...

Nicholas Ramirez
Thanks for the change to the ok and result.

  • To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
  • Also move the:
    ; if ( ! ok ) { goto invalid; }
    

    on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

APPROVED

APPROVED